Draft
Conversation
c-gr34sl3y
commented
Apr 9, 2025
| @@ -0,0 +1,83 @@ | |||
| name: check-contrib | |||
|
|
|||
| on: [push, pull_request] # would you need to define PRs containing .eb files? | |||
Contributor
Author
There was a problem hiding this comment.
Since the workflow is triggered on all push and pull request events, should I add a conditional to only run the check-contrib step if .eb files are modified?
e.g. if: contains(github.event.pull_request.changed_files, '.eb')
c-gr34sl3y
commented
Apr 9, 2025
| pip install easybuild==4.9.4 pycodestyle | ||
|
|
||
| echo "Installing LMOD" | ||
| sudo apt-get install -y lua5.2 liblua5.2-dev lua-filesystem lua-posix tcl tcl-dev |
Contributor
Author
There was a problem hiding this comment.
This install section is a bit messy. It can be tidied up. Add neater lines to a variable and then
$APT_APPS_INSTALL _LIST= lua5.2 liblua5.2-dev lua-filesystem lua-posix tcl tcl-dev curl
sudo apt-get install -y $APT_APPS_INSTALL_LIST
c-gr34sl3y
commented
Apr 9, 2025
| - name: Upgrade pip | ||
| run: python -m pip install --upgrade pip | ||
|
|
||
| - name: Install EasyBuild and required deps |
Contributor
Author
There was a problem hiding this comment.
Add caching for Python dependencies using actions/cache@v3 to speed up subsequent runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the idea is to get
eb --check-contribto run on new PRs and push actions to the repo.This is a rough draft. Some things to work on and test more: