refactor: replace BB.Message.Payload protocol with use BB.Message macro.
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… macro Remove the redundant protocol that only delegated to the module's `schema/0` callback. The new macro handles all boilerplate: - Sets up `@behaviour BB.Message` - Compiles the schema via `Spark.Options` - Generates `schema/0` callback and `new/2` helper Also fixes a race condition in command execution where state transitions happened asynchronously after completion events were published. Now uses synchronous `GenServer.call` to ensure state updates before subscribers receive events. Net reduction of ~290 lines across 21 files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the redundant protocol that only delegated to the module's
schema/0callback. The new macro handles all boilerplate:@behaviour BB.MessageSpark.Optionsschema/0callback andnew/2helperAlso fixes a race condition in command execution where state transitions happened asynchronously after completion events were published. Now uses synchronous
GenServer.callto ensure state updates before subscribers receive events.Net reduction of ~290 lines across 21 files.