fix: use __invoke to inject request classes on invokable controller#118
Open
chuckadams wants to merge 1 commit intobeacon-hq:mainfrom
Open
fix: use __invoke to inject request classes on invokable controller#118chuckadams wants to merge 1 commit intobeacon-hq:mainfrom
chuckadams wants to merge 1 commit intobeacon-hq:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a single-action controller with an
__invokemethod,$route->getActionMethod()will return the name of the controller instead of any usable method, so we end up getting baffling errors about methods likeApp\Http\Controllers\My\Controller::App\Http\Controllers\My\Controller()not existing. Arguably this is a bug in Laravel, but we have to work around it, so this detects if the method is identical to the controller, and switches it to__invokeif so.