fix: Tab draggable from full area including padding#1315
Merged
Conversation
Co-authored-by: bdlukaa <45696119+bdlukaa@users.noreply.github.com> Agent-Logs-Url: https://github.com/bdlukaa/fluent_ui/sessions/3c521cc5-1017-4438-9903-74874398ed0e
Copilot
AI
changed the title
[WIP] Fix tab not draggable in its padding area
fix: Tab draggable from full area including padding
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tabs in
TabViewcould not be drag-reordered from their padding area — only the inner content region responded to drag gestures, despite the full tab area being clickable.Root cause:
ReorderableDragStartListenerwas placed as the child of theContainer(inside the padding), so pointer events landing in the padding were consumed by theContainerwithout reaching the listener.Fix (
tab.dart): MovedReorderableDragStartListenerto wrap the entireContainer(including its padding) rather than its interior content:Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.