Skip to content

Conversation

@filmakarov
Copy link
Collaborator

@filmakarov filmakarov commented Nov 1, 2025

  • Rm registry
  • Rm K1 factory
  • RM meta factory
  • fix all the tests etc

PR-Codex overview

This PR focuses on the removal of several files related to the K1ValidatorFactory and BiconomyMetaFactory, transitioning to a new NexusAccountFactory. It also simplifies the initialization process for smart accounts by removing unnecessary registry configurations and related code.

Detailed summary

  • Deleted multiple files including deploy.ts, MockRegistry.sol, and K1ValidatorFactory.sol.
  • Replaced K1ValidatorFactory references with NexusAccountFactory across various tests and scripts.
  • Simplified account initialization by removing RegistryConfig usage in several functions.
  • Updated initialization functions in NexusBootstrap to streamline module setup.
  • Adjusted tests to align with the new account factory structure and initialization process.

The following files were skipped due to too many changes: contracts/utils/NexusBootstrap.sol

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@filmakarov filmakarov merged commit ed34991 into dev Nov 1, 2025
5 checks passed
@filmakarov filmakarov deleted the chore/rm-registry-support branch November 1, 2025 10:37
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

🤖 Slither Analysis Report 🔎

Slither report

Details # Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - unused-return (2 results) (Medium)

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

base/ModuleManager.sol#L234-L243

base/ModuleManager.sol#L264-L268

_This comment was automatically generated by the GitHub Actions workflow._

@openzeppelin-code
Copy link

Cleanup

Generated at commit: 1e594b8a40671718c9c627767f183251afe3a8f2

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
0
0
7
30
38

For more details view the full report in OpenZeppelin Code Inspector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants