Skip to content

Conversation

@filmakarov
Copy link
Collaborator

@filmakarov filmakarov commented Oct 21, 2025

Fix https://github.com/PashovAuditGroup/Biconomy_October25_MERGED/issues/1


PR-Codex overview

This PR focuses on enhancing the initialization process in the Nexus contract by adding checks to prevent re-initialization of accounts and to ensure that the initialization data hash has not been previously used.

Detailed summary

  • Added a check to ensure the account has not been already initialized using require(!isInitialized(), AccountAlreadyInitialized());
  • Implemented a validation for the initialization hash to confirm it has not been used before: require(!$accountStorage.erc7702InitHashes[initDataHash], AccountAlreadyInitialized());

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@github-actions
Copy link

🤖 Slither Analysis Report 🔎

Slither report

Details # Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - unused-return (2 results) (Medium)

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

base/ModuleManager.sol#L236-L245

base/ModuleManager.sol#L267-L271

_This comment was automatically generated by the GitHub Actions workflow._

@openzeppelin-code
Copy link

fix [L-01] reinit via relay

Generated at commit: 0b64d292db2b5843d7f8f30419e9c481f137628d

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
7
30
39

For more details view the full report in OpenZeppelin Code Inspector

@filmakarov filmakarov merged commit e7ddce9 into dev Oct 31, 2025
5 of 8 checks passed
@filmakarov filmakarov deleted the fix/L-01-relay-reinit-issue branch October 31, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants