Skip to content

chore: add solhint and rules#43

Merged
filmakarov merged 26 commits intochore/clean-git-submodulesfrom
feat/add-solhint-other-repo-improvements
Oct 2, 2025
Merged

chore: add solhint and rules#43
filmakarov merged 26 commits intochore/clean-git-submodulesfrom
feat/add-solhint-other-repo-improvements

Conversation

@filmakarov
Copy link
Contributor

@filmakarov filmakarov commented Sep 30, 2025

PR-Codex overview

This PR focuses on improving the codebase by optimizing imports, enhancing linting configurations, and adding new workflows for Solidity linting and Foundry tests. It also includes updates to contracts and test files for better readability and functionality.

Detailed summary

  • Removed .github/workflows/test.yml.solhintignore.
  • Added node_modules/, lib/, and scripts/ to .gitignore.
  • Updated IMEE.sol to have a space after the interface declaration.
  • Created .solhint.json with custom rules.
  • Refactored import statements for consistency.
  • Adjusted foundry.toml settings for line length and verbosity.
  • Added changelog entries in CHANGELOG.md.
  • Updated remappings.txt for rlp-reader.
  • Improved formatting in several Solidity files for readability.
  • Added new GitHub workflows for Solidity linting and Foundry tests.
  • Enhanced error handling in EtherForwarder contract.
  • Versioning added to NodePaymaster and NodePaymasterFactory.
  • Refactored functions to improve clarity and maintainability.
  • Added event emissions in EmittingNodePaymaster.
  • Updated test cases for consistency and improved readability.
  • General code clean-up and linting improvements across multiple files.

The following files were skipped due to too many changes: test/unit/node-paymaster/fixed-premium/FixedPremium_Test.t.sol, contracts/BaseNodePaymaster.sol, test/unit/node-paymaster/percentage-premium/PercentagePremium_Test.t.sol, contracts/validators/K1MeeValidator.sol, test/Base.t.sol, pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@filmakarov filmakarov merged commit 538f334 into chore/clean-git-submodules Oct 2, 2025
2 checks passed
@filmakarov filmakarov deleted the feat/add-solhint-other-repo-improvements branch October 2, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant