New Fusioin Mode: MetaMask Delegation Toolkit mode#39
Draft
filmakarov wants to merge 12 commits intomainfrom
Draft
New Fusioin Mode: MetaMask Delegation Toolkit mode#39filmakarov wants to merge 12 commits intomainfrom
filmakarov wants to merge 12 commits intomainfrom
Conversation
added 10 commits
April 18, 2025 10:38
fichiokaku
reviewed
Jun 19, 2025
| } | ||
| } | ||
|
|
||
| return _packValidationData(false, decodedSig.upperBoundTimestamp, decodedSig.lowerBoundTimestamp); |
Collaborator
There was a problem hiding this comment.
shouldn't the order here be:
(false, lowerBoundTimestamp, upperBoundTimestamp
?
Contributor
Author
There was a problem hiding this comment.
no, it's (isValidationFailed, validUntil, validAfter)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flow is like this:
Current implementation expects the delegation to be restricted by the only caveat which is the
exactExecutioncaveat, wherecalldataparam has the superTxHash appended to it.See https://docs.gator.metamask.io/how-to/create-delegation/restrict-delegation#exactexecution
PR-Codex overview
This PR introduces a new
MockDelegationManagercontract and enhances the delegation functionality within the project. It adds support for MM delegation signatures, modifies existing validation logic, and updates related tests to ensure functionality for the new delegation type.Detailed summary
MockDelegationManagercontract with agetDomainHashfunction.SIG_TYPE_MM_DELEGATIONinConstants.sol.K1MeeValidatorto handleMmDelegationValidatorLib.K1MeeValidator.MMDelegationHelpers.sol.MmDelegationValidatorLib.MM_DTK_Test_Fork.t.solandK1MEEValidator_Test.t.sol.