Conversation
size-limit report 📦
|
|
1 test case failed because of the hook timeout glitch. So all good |
src/sdk/modules/validators/smartSessions/decorators/mee/prepareForPermissions.ts
Outdated
Show resolved
Hide resolved
src/sdk/modules/validators/smartSessions/decorators/mee/prepareForPermissions.ts
Outdated
Show resolved
Hide resolved
src/sdk/modules/validators/smartSessions/decorators/mee/prepareForPermissions.ts
Outdated
Show resolved
Hide resolved
src/sdk/modules/validators/smartSessions/decorators/mee/prepareForPermissions.ts
Outdated
Show resolved
Hide resolved
src/sdk/modules/validators/smartSessions/decorators/mee/prepareForPermissions.ts
Show resolved
Hide resolved
|
just one thing I've noticed: If the user already has an action for the fee token (same selector + address) but with a policy that is not SPENDING_LIMITS_POLICY_ADDRESS (e.g. only usage or time-frame), the code leaves that action unchanged and does not add a separate payment action (isPolicyForPaymentTokenExists is true). So the session might not have a spending limit for fees So could we:
|
|
calldataArgument is exported from buildActionPolicy and used in tests and in prepare-for-smart-session. Should we in general export this to our sdk users? |
|
@fichiokaku The payment policy checks happens and if its missing its being added here. So we're good here |
This is a good catch, I wanted this to be exported for developers as well. Will fix this UPDATED: Its fixed |
* feat: build action and action policy abstrations * chore: code formats * feat: added some improvements and test coverage * chore: code formats * test: added test coverage * chore: code formats * feat: fixed some test issues * feat: smart sessions enable permission action split (#183) * feat: smart sessions permission action split * feat: added module install dependencies via conditions * chore: code formats * feat: added conditional dependency for enable permissions * feat: build batch actions implemented * feat: code formatting * feat: refactored the legacy payment policy logics * chore: code formats * feat: smart session abstraction 2 (#185) * feat: smart session abstraction 2 * feat: refactored the prepareForPermission code flow * feat: added test coverage for broad cases * chore: code formats * feat: added more test coverage * chore: code formats * feat: added debug mode for consoles * feat: minor improvements and test coverage * chore: code formats * feat: smart sessions revamp pr fixes (#186) * feat: fixed all the pr suggestions * chore: code formats * feat: payment policy logic is refactored * feat: increased the build size * fix: build issue fixed * feat: fixed the time units * feat: modified the tests * feat: addressed pr comments
* chore: merge mee3 support * chore: add support for stx validator initdata * chore: lint * chore: add unit tests for session validator initdata generation * chore: lint --------- Co-authored-by: Filipp Makarov <fmc@Filipps-MacBook-Pro.local>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #181 +/- ##
===========================================
+ Coverage 73.28% 77.73% +4.45%
===========================================
Files 265 284 +19
Lines 9404 11450 +2046
Branches 1325 1597 +272
===========================================
+ Hits 6892 8901 +2009
- Misses 2512 2549 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Paid tests are passing: https://github.com/bcnmy/abstractjs/actions/runs/22619772898/job/65541617020 |
PR-Codex overview
This PR introduces a
debug modefor the SDK, enhancing error logging and adding new functionalities for session management and action policies. It also refines existing methods and types to support these features, improving overall usability and clarity.Detailed summary
isDebugModeproperty in several interfaces.signSessionQuoteandexecuteSessionQuotefunctions for session management.console.errorwhenisDebugModeis true.simulationOverrides.