Print out command line arguments for pkbootimage after splitting image#1
Open
philippelatulippe wants to merge 1 commit intobclary:masterfrom
Open
Print out command line arguments for pkbootimage after splitting image#1philippelatulippe wants to merge 1 commit intobclary:masterfrom
philippelatulippe wants to merge 1 commit intobclary:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for writing this useful program. It came in really handy when I wanted to make some small changes to my Nexus 4 boot image but found that most splitting scripts don't take in account the Nexus' non-standard offsets in the header.
To save time when repackaging the image, I added some code that makes spbootimage print out the command line to use with pkbootimage. The only extra change I had to make was to write_chunk, which I made accept arbitrary output file names instead of concatenating the name itself.
I tested it with my Nexus 4, and the repackaged boot.img came out identical as the input.