fix: powerbi url #562
Merged
fix: powerbi url #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request renames the runtime configuration endpoint from /config.js to /env.js to better reflect that it handles environment variables. The changes ensure that the environment configuration (including PowerBI URL) is properly injected into the built HTML and served by Caddy.
Changes:
- Added a custom Vite plugin to inject the
/env.jsscript tag into the HTML head during build - Renamed the Caddy endpoint from
/config.jsto/env.jswith updated header syntax - Updated the SPA router configuration to exclude
/env.jsfrom redirects - Applied code formatting improvements (quote style consistency and trailing commas)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/vite.config.js | Added build-html plugin to inject env.js script tag and updated formatting to use double quotes |
| frontend/Caddyfile | Renamed config endpoint from /config.js to /env.js and updated SPA router exclusions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the PR!
Any successful deployments (not always required) will be available below.
API available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow