fix: api layer ingress #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds a new api.ingress configuration to the Helm chart values, providing enhanced ingress configuration with rate limiting, load balancing, and multiple host/path support. The template is updated to support both the new ingress structure and maintain backward compatibility with the existing route configuration.
Changes:
- Added comprehensive
api.ingressconfiguration in values.yaml with OpenShift-specific annotations for rate limiting and load balancing - Updated ingress.yaml template to support both the new
hostsarray structure and legacy singlehostconfiguration - Implemented fallback logic to use
api.routeconfiguration whenapi.ingressis not defined
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/pubcode/values.yaml | Adds new api.ingress section with rate limiting, load balancing annotations, and hosts configuration while keeping existing api.route |
| charts/pubcode/templates/api/templates/ingress.yaml | Refactors template to support both new ingress structure with multiple hosts/paths and legacy route structure with backward compatibility fallback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the PR!
Any successful deployments (not always required) will be available below.
API available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow