fix: remove helm service dependency and fix mongo image reference #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR removes the external helm-service dependency and inlines the component templates directly into the chart. The database configuration is updated to reference a custom-built database image instead of directly using the external mongo image.
Changes:
- Removed helm-service dependency from Chart.yaml and deleted Chart.lock
- Inlined Helm templates for api, frontend, and database components (previously sourced from external component chart)
- Updated database image references to use project-specific database image with global registry/repository configuration
- Added defensive
default ""wrapper for optional powerBIURL secret value - Updated CI/CD workflows to build, deploy, and cleanup the database package alongside api and frontend
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/pubcode/Chart.yaml | Removed external component chart dependencies |
| charts/pubcode/Chart.lock | Deleted lock file for removed dependencies |
| charts/pubcode/values.yaml | Changed database image from external mongo to project-specific database image using global registry/repository pattern |
| charts/pubcode/templates/secret.yaml | Added defensive default empty string for optional powerBIURL |
| charts/pubcode/templates/frontend/templates/*.yaml | Added inlined frontend component templates (service, pdb, ingress, hpa, deployment) |
| charts/pubcode/templates/frontend/templates/_helpers.tpl | Added frontend template helper functions |
| charts/pubcode/templates/database/templates/*.yml | Added inlined database component templates (sfs, service, pvc) |
| charts/pubcode/templates/database/templates/_helpers.tpl | Added database template helper functions with compatibility aliases |
| charts/pubcode/templates/api/templates/*.yml | Added inlined api component templates (service, pdb, ingress, hpa, deployment) |
| charts/pubcode/templates/api/templates/_helpers.tpl | Added api template helper functions |
| .github/workflows/pr-open.yml | Added database to build matrix and deployment parameters |
| .github/workflows/pr-close.yml | Added database to cleanup packages list |
| .github/workflows/merge.yml | Added database to retag matrix and deployment parameters for test and prod environments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the PR!
Any successful deployments (not always required) will be available below.
API available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow