31394 - Fix amendment response for trust indenture #2269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndenture Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
chenhongjing
commented
Dec 2, 2025
doug-lovett
approved these changes
Dec 2, 2025
Collaborator
doug-lovett
left a comment
doug-lovett
left a comment
There was a problem hiding this comment.
Looks good, could you also increase the version in pyproject.toml.
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#31394
Description of changes:
addTrustIndentureandremoveTrustIndenturewill incorrectly return in response. The ticket only describes one scenario, but this fix is to resolve all the scenarios.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).