Queued Transfer Footer Component #2254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameron-eyds
reviewed
Oct 3, 2025
Comment on lines
1125
to
1150
| export async function updateQueuedTransfer ( | ||
| reviewId: string, payload: any | ||
| ): Promise<QueueDetailIF | any> { | ||
| try { | ||
| const response = await axios.patch<QueueDetailIF>( | ||
| `reviews/${reviewId}`, | ||
| payload, | ||
| getDefaultConfig() | ||
| ) | ||
| const data: QueueDetailIF = response?.data | ||
| if (!data) { | ||
| throw new Error('Invalid API response') | ||
| } | ||
| return data | ||
| } catch (error: AxiosError | any) { | ||
| if (error.response && error.response.status === 404) { | ||
| console.error('Resource not found:', error.message) | ||
| // Handle 404 gracefully, returning null | ||
| return null | ||
| } else { | ||
| // Handle other errors differently if needed | ||
| console.error('API Error:', error.message) | ||
| throw error | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Maybe include a payload IF, even if it's a simple interface inline.
ie payload: { statusType: ReviewStatusTypes }
QQ: The assignee value (ie current user) is captured and applied api side?
Contributor
Author
There was a problem hiding this comment.
Yep, I will add type for the payload.
Answer: If the assignee value is empty, the staff user submitting the request is the assignee.
cameron-eyds
approved these changes
Oct 3, 2025
Collaborator
cameron-eyds
left a comment
cameron-eyds
left a comment
There was a problem hiding this comment.
Spectacular! Just one comment/question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#20492
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).