API: Unrestricted rule for home dealers #2060
Conversation
| error_msg += validator_utils.validate_registration_state( | ||
| registration, staff, MhrRegistrationTypes.PERMIT, MhrDocumentTypes.REG_103, json_data | ||
| ) | ||
| if registration and group_name and group_name == MANUFACTURER_GROUP: |
There was a problem hiding this comment.
From the ticket description the removal of the restriction applies only to dealers. MANUFACTURER_GROUP applies to QS manufactures, which I do not think has changed.
There was a problem hiding this comment.
Definitely correct, only Dealers are changing.
There was a problem hiding this comment.
Yep! I will update it.
| ('Missing land status confirm MH_PARK', False, '000900', LOCATION_PARK_2, | ||
| validator_utils.STATUS_CONFIRMATION_REQUIRED, | ||
| REQUEST_TRANSPORT_PERMIT), | ||
| ('MANUFACTURER no existing lot', False, '000919', None, validator.MANUFACTURER_DEALER_INVALID, |
There was a problem hiding this comment.
If the validation change only applies to QS dealers then the manufacturer tests can remain as is.
There was a problem hiding this comment.
I will revert this change!
doug-lovett
left a comment
doug-lovett
left a comment
There was a problem hiding this comment.
Looks good, just a comment on scope - if QS manufacturer validation is changing? From the ticket description it looks like only QS dealer validation is changing.
* Enhanced Dealer Updates * clean up * Added Script Commands
* Dealer Civic Location Addition * Version Bump
* MHR API QS dealer endpoint updates Signed-off-by: Doug Lovett <doug@diamante.ca> * MHR API update lock file. Signed-off-by: Doug Lovett <doug@diamante.ca> --------- Signed-off-by: Doug Lovett <doug@diamante.ca>
3 participants
Issue #: /bcgov/entity#24056
Description of changes:
NOTE: Since I am not comfortable to update the DB yet, I left the other 2 tasks.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).