Skip to content

Conversation

@ochiu
Copy link
Collaborator

@ochiu ochiu commented Dec 17, 2025

Issue #: bcgov/entity#31418

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the pay-ui license (Apache 2.0).

@ochiu ochiu requested review from Jxio and seeker25 as code owners December 17, 2025 20:24
watch(() => state.filters, (filters: any) => {
ConfigHelper.addToSession(SessionStorageKeys.LinkedShortNamesFilter, JSON.stringify(filters.filterPayload))
}, { deep: true })
watch(() => state.tableDataOptions, (val: DataOptions) => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix paging on refund requests table

})
const headers = [
createHeader(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback to add transaction id filter for refund requests table, API already supports this

::v-deep .v-data-table > .v-data-table__wrapper>table {
min-height: 215px;
::v-deep .transaction-list .v-data-table__wrapper {
min-height: 240px;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patty found issue in firefox where more actions are cut off. This resolves the issue for both chrome and firefox. Previous CSS didn't affect firefox.

invoiceProduct: null as string | null
})
const paymentMethodCodesAllowedPartialRefunds = ['DIRECT_PAY', 'EFT', 'EJV', 'ONLINE_BANKING', 'PAD']
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to hardcode this, states come back from API now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@ochiu ochiu merged commit 9812dea into bcgov:main Dec 17, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants