30614 Add expiration date validation to edit #1583
Conversation
eve-git
requested review from
mengdong19,
ozamani9gh,
rarmitag,
shaangill025 and
stevenc987
as code owners
| <LoadingSpinner v-if="search.isLoading" /> | ||
| </div> | ||
|
|
||
| <PopupDialog :show="showDateDialog"> |
There was a problem hiding this comment.
fixed the warning:
| optionsDisplay: (option: any) => option, | ||
| } | ||
| ) | ||
| }>() |
There was a problem hiding this comment.
Fixed the warning: withDefaults() is unnecessary when using destructure with defineProps().
| <LoadingSpinner v-if="isLoading" /> | ||
| </div> | ||
|
|
||
| </div> |
There was a problem hiding this comment.
Fixed the warning:
|
/gcbrun |
|
Temporary Url for review: https://namex-dev--pr-1583-67s66qmy.web.app |
hfekete
left a comment
hfekete
left a comment
There was a problem hiding this comment.
Looks good!
There is one comment, please check it and see if you want to act on it.
app/components/search/ResultsBox.vue
Outdated
| </table> | ||
|
|
||
| <div class="absolute bottom-1/2 right-1/2 translate-x-1/2 translate-y-1/2 transform"> | ||
| <LoadingSpinner v-if="search.isLoading" /> |
There was a problem hiding this comment.
you could try moving the v-if="search.isLoading" in the div above:
<div v-if="search.isLoading" class=absolute...
I think it should work, and entire div would be out of the page when loading is not set to true.
Otherwise, div is there, though probably of size 0 or 1px or smth like that.
But if this works, and that div is not in the way of the page it can stay.
app/pages/Stats.vue
Outdated
| </div> | ||
| </table> | ||
| <div class="absolute bottom-1/2 right-1/2 translate-x-1/2 translate-y-1/2 transform"> | ||
| <LoadingSpinner v-if="isLoading" /> |
There was a problem hiding this comment.
same as above for the v-if
|
/gcbrun |
|
Temporary Url for review: https://namex-dev--pr-1583-67s66qmy.web.app |
2 participants
Issue #:
https://app.zenhub.com/workspaces/names-team-board-new-655554cbddd49510027dad2e/issues/gh/bcgov/entity/30614
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).