-
Notifications
You must be signed in to change notification settings - Fork 10
prod release #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: prod-release
Are you sure you want to change the base?
prod release #63
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
SonarCloud Quality Gate failed.
|
|
SonarCloud Quality Gate failed.
|
|
SonarCloud Quality Gate failed.
|
Ticket 3968: Bug Fix
Ticket 3968: Bug Fix part 2
|
DEV<>Master Merge
FOI Request Form Updates - New Ministry Name Update : Ministry of Jobs, Economic Development and Innovation to Ministry of Jobs and Economic Growth
FOIMOD-4142 - FOI Request Form Updates - New Ministry Name Update
FOIMOD-4142 - FOI Request Form Updates - New Ministry Name Update
|
web/src/app/route-components/childprotection-child/childprotection-child.component.ts
Fixed
Show fixed
Hide fixed
web/src/app/route-components/childprotection-parent/childprotection-parent.component.ts
Fixed
Show fixed
Hide fixed
web/src/app/route-components/choose-identity/choose-identity.component.ts
Fixed
Show fixed
Hide fixed
web/src/app/route-components/youthincare-child/youthincare-child.component.ts
Fixed
Show fixed
Hide fixed
web/src/app/route-components/youthincare-parent/youthincare-parent.component.ts
Fixed
Show fixed
Hide fixed
| runs-on: ubuntu-24.04 | ||
|
|
||
| if: github.event_name == 'push' && github.repository == 'bcgov/foi-requests' | ||
| environment: | ||
| name: "dev" | ||
|
|
||
| steps: | ||
| - name: Install oc | ||
| uses: redhat-actions/oc-installer@v1 | ||
| with: | ||
| oc_version: '4.6' | ||
|
|
||
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: Install oc | ||
| uses: redhat-actions/oc-installer@v1 | ||
| with: | ||
| oc_version: '4.6' | ||
|
|
||
| - name: Login Openshift | ||
| shell: bash | ||
| run: | | ||
| oc login --server=${{secrets.OPENSHIFT4_LOGIN_REGISTRY}} --token=${{secrets.OPENSHIFT4_SA_TOKEN}} | ||
|
|
||
| - name: Tools project | ||
| shell: bash | ||
| run: | | ||
| oc project ${{ secrets.OPENSHIFT4_FRONTEND_REPOSITORY }}-tools | ||
|
|
||
| - name: Build from text branch | ||
| shell: bash | ||
| run: | | ||
| oc patch bc/api-master-build -p '{"spec":{"source":{"git":{"ref":"dev"}}}}' | ||
|
|
||
| - name: Start Build Openshift | ||
| shell: bash | ||
| run: | | ||
| oc start-build api-master-build --wait | ||
|
|
||
| - name: Tag+Deploy for dev | ||
| shell: bash | ||
| run: | | ||
| oc tag api:latest api:${{ env.TAG_NAME }} | ||
|
|
||
| - name: Rollout Restart Deployment | ||
| shell: bash | ||
| run: | | ||
| oc project 04d1a3-dev | ||
| oc rollout restart deployment/api |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 7 months ago
To address the issue, we need to explicitly define the permissions key in the workflow file. Since the workflow appears to perform actions such as checking out code (contents: read) and deploying an application, it is likely that the contents: read permission is sufficient. If the workflow requires additional permissions (e.g., pull-requests: write), they should also be specified explicitly. The permissions key can be added at the root level of the workflow to apply to all jobs, or it can be added to individual jobs if different permissions are required for different jobs.
-
Copy modified lines R18-R20
| @@ -15,6 +15,9 @@ | ||
| required: true | ||
| default: "dev" | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash |
| runs-on: ubuntu-24.04 | ||
|
|
||
| if: github.event_name == 'push' && github.repository == 'bcgov/foi-requests' | ||
| environment: | ||
| name: "test" | ||
|
|
||
| steps: | ||
| - name: Install oc | ||
| uses: redhat-actions/oc-installer@v1 | ||
| with: | ||
| oc_version: '4.6' | ||
|
|
||
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: Login Openshift | ||
| shell: bash | ||
| run: | | ||
| oc login --server=${{secrets.OPENSHIFT4_LOGIN_REGISTRY}} --token=${{secrets.OPENSHIFT4_SA_TOKEN}} | ||
|
|
||
| - name: Tools project | ||
| shell: bash | ||
| run: | | ||
| oc project ${{ secrets.OPENSHIFT4_FRONTEND_REPOSITORY }}-tools | ||
|
|
||
| - name: Build from text branch | ||
| shell: bash | ||
| run: | | ||
| oc patch bc/api-master-build -p '{"spec":{"source":{"git":{"ref":"master"}}}}' | ||
|
|
||
| - name: Start Build Openshift | ||
| shell: bash | ||
| run: | | ||
| oc start-build api-master-build --wait | ||
|
|
||
| - name: Tag+Deploy for test | ||
| shell: bash | ||
| run: | | ||
| oc tag api:latest api:${{ env.TAG_NAME }} | ||
|
|
||
| - name: Rollout Restart Deployment | ||
| shell: bash | ||
| run: | | ||
| oc project 04d1a3-test | ||
| oc rollout restart deployment/api |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 9 months ago
To fix the issue, we will add a permissions block at the workflow level to explicitly define the minimal permissions required. Based on the workflow's actions, it primarily interacts with the repository contents (e.g., checking out code) and does not appear to require write access. Therefore, we will set contents: read as the permission. This ensures that the GITHUB_TOKEN has only the necessary permissions to perform the workflow tasks.
-
Copy modified lines R3-R4
| @@ -2,2 +2,4 @@ | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
| runs-on: ubuntu-24.04 | ||
|
|
||
| if: github.event_name == 'push' && github.repository == 'bcgov/foi-requests' | ||
| environment: | ||
| name: "dev" | ||
|
|
||
| steps: | ||
| - name: Install oc | ||
| uses: redhat-actions/oc-installer@v1 | ||
| with: | ||
| oc_version: '4.6' | ||
|
|
||
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: Install oc | ||
| uses: redhat-actions/oc-installer@v1 | ||
| with: | ||
| oc_version: '4.6' | ||
|
|
||
| - name: Login Openshift | ||
| shell: bash | ||
| run: | | ||
| oc login --server=${{secrets.OPENSHIFT4_LOGIN_REGISTRY}} --token=${{secrets.OPENSHIFT4_SA_TOKEN}} | ||
|
|
||
| - name: Tools project | ||
| shell: bash | ||
| run: | | ||
| oc project ${{ secrets.OPENSHIFT4_FRONTEND_REPOSITORY }}-tools | ||
|
|
||
| - name: Build from text branch | ||
| shell: bash | ||
| run: | | ||
| oc patch bc/web-artifact-build -p '{"spec":{"source":{"git":{"ref":"dev"}}}}' | ||
|
|
||
| - name: Start Build Openshift part 1/2 | ||
| shell: bash | ||
| run: | | ||
| oc start-build web-artifact-build --wait | ||
|
|
||
| - name: Start Build Openshift part 2/2 | ||
| shell: bash | ||
| run: | | ||
| oc start-build web-image-build --wait | ||
|
|
||
| - name: Tag+Deploy for dev | ||
| shell: bash | ||
| run: | | ||
| oc tag web:latest web:${{ env.TAG_NAME }} | ||
|
|
||
| - name: Rollout Restart Deployment | ||
| shell: bash | ||
| run: | | ||
| oc project 04d1a3-dev | ||
| oc rollout restart deployment/web |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 7 months ago
To fix this issue, add a permissions block to the workflow. Ideally, this block should be placed at the root level of the workflow to apply the permissions globally to all jobs. Based on the workflow's usage, the minimum required permissions are likely contents: read since there are no GitHub-related write operations like creating pull requests or dispatching workflows. This will limit the GITHUB_TOKEN to read-only access to repository contents, adhering to the principle of least privilege.
-
Copy modified lines R3-R4
| @@ -1,5 +1,7 @@ | ||
| name: Deploy web to dev | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
| runs-on: ubuntu-24.04 | ||
|
|
||
| if: github.event_name == 'push' && github.repository == 'bcgov/foi-requests' | ||
| environment: | ||
| name: "test" | ||
|
|
||
| steps: | ||
| - name: Install oc | ||
| uses: redhat-actions/oc-installer@v1 | ||
| with: | ||
| oc_version: '4.6' | ||
|
|
||
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: Login Openshift | ||
| shell: bash | ||
| run: | | ||
| oc login --server=${{secrets.OPENSHIFT4_LOGIN_REGISTRY}} --token=${{secrets.OPENSHIFT4_SA_TOKEN}} | ||
|
|
||
| - name: Tools project | ||
| shell: bash | ||
| run: | | ||
| oc project ${{ secrets.OPENSHIFT4_FRONTEND_REPOSITORY }}-tools | ||
|
|
||
| - name: Build from master branch | ||
| shell: bash | ||
| run: | | ||
| oc patch bc/web-artifact-build -p '{"spec":{"source":{"git":{"ref":"master"}}}}' | ||
|
|
||
| - name: Start Build Openshift part 1/2 | ||
| shell: bash | ||
| run: | | ||
| oc start-build web-artifact-build --wait | ||
|
|
||
| - name: Start Build Openshift part 2/2 | ||
| shell: bash | ||
| run: | | ||
| oc start-build web-image-build --wait | ||
|
|
||
| - name: Tag+Deploy for test | ||
| shell: bash | ||
| run: | | ||
| oc tag web:latest web:${{ env.TAG_NAME }} | ||
|
|
||
| - name: Rollout Restart Deployment | ||
| shell: bash | ||
| run: | | ||
| oc project 04d1a3-test | ||
| oc rollout restart deployment/web |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 9 months ago
To fix the issue, we will add a permissions block at the root level of the workflow. This block will specify the least privileges required for the workflow to function correctly. Based on the workflow's steps, it primarily interacts with OpenShift and does not seem to require write access to the repository. Therefore, we will set contents: read as the minimal permission.
-
Copy modified lines R3-R4
| @@ -2,2 +2,4 @@ | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
Dev disclaimer strike
Disclaimer for Job Action on Base component html - !!!need to remove after strike
|
update disclaimer regarding job action
update job action banner
remove disclaimer
remove job action banner
|












No description provided.