31672 Fixed Special Resolution ID parameter #242
Conversation
- fixed Special Resolution ID parameter
severinbeauvais
requested review from
Rajandeep98,
TVWerdal,
ketaki-deodhar and
meawong
as code owners
|
/gcbrun |
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Special Resolution ID parameter naming. The parameter name used when resuming a Special Resolution filing draft was inconsistent with the naming convention used for other filing types.
- Updated the parameter name from
'special-resolution'to'special-resolution-id'to align with the established pattern - Bumped the app version from 1.1.28 to 1.1.29
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/utils/todo/action-functions.ts | Fixed the parameter name to follow the consistent naming pattern used by other filing types (e.g., 'alteration-id', 'correction-id', 'change-id') |
| package.json | Version bump to 1.1.29 reflecting the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Temporary Url for review: https://business-dashboard-dev--pr-242-kghzgtl3.web.app SB says, try resuming the Special Resolution here: https://business-dashboard-dev--pr-242-kghzgtl3.web.app/CP1002537. Look at the new URL -- should contain "special-resolution-id=...". |
| navigateFn = goToEditUI | ||
| path = `/${currentBusinessIdentifier}/special-resolution/` | ||
| params = { 'special-resolution': item.filingId.toString() } | ||
| params = { 'special-resolution-id': item.filingId.toString() } |
There was a problem hiding this comment.
Edit UI expects the param to be named "special-resolution-id".
I checked the other IDs sent from Business Dashboard to Edit UI; they're all fine.
This must have been an omission when the Business Dashboard was rewritten a year ago.
3 participants
Issue: bcgov/entity#31672
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).