31526 + 31543: Display pending maintenance filings in History instead of To Do + Update Court Order action buttons #240

severinbeauvais · 2025-12-03T21:28:56Z

Issue: bcgov/entity#31526 + bcgov/entity#31543

Description of changes:

added subtitle for pending filings
added body for pending filings
misc cleanup
added header actions for Court Order when not staff
added header actions for pending filings
added component for pending subtitle
added general filing strings for pending filings
fixed string key typo for dissolution sub types
ensured todos and filings lists are clear before dashboard is mounted
now push instead of assign new filings into filings list
added method to insert a filing into filings list
if task is a pending-payment-completed maintenance filing then insert it into filings list instead of todos list
added todo utils to check task type and convert task to filing
fixed businessCached check
changed "screen" -> "page" (per Jacqueline)
fixed const in composable
fixed e2e tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

- added body for pending filings - misc cleanup - added header actions for Court Order when not staff - added header actions for pending filings - added component for pending subtitle - added general filing strings for pending filings - fixed string key typo for dissolution sub types - ensure todos and filings lists are clear before dashboard is mounted - now push instead of assign new filings into filings list - add method to insert a filing into filings list - if task is a pending-payment-completed maintenance filing then insert it into filings list instead of todos list - add todo utils to check task type and convert task to filing

Copilot

Pull request overview

This pull request implements functionality to display pending maintenance filings with "Payment Completed" status in the Filing History section instead of the To Do section. The changes enhance the user experience by properly categorizing filings and providing appropriate UI feedback for pending filings.

Modified the todo store to identify and redirect pending maintenance filings to the filings list
Added utility functions to distinguish maintenance filings from bootstrap tasks and check payment completion status
Enhanced UI components to display pending filings with appropriate subtitles, body content, and header actions

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/utils/todo/task-filing/index.ts	Added blank line for code formatting
src/utils/todo/index.ts	Added utility functions to identify maintenance filings, check payment status, and convert tasks to filing items
src/stores/todo.ts	Modified task loading logic to redirect pending maintenance filings to filings list instead of todos
src/stores/filings.ts	Changed loadFilings to append filings using push instead of assignment; added insertFiling method to add filings at the beginning of the list
src/pages/dashboard.vue	Added clear calls for todos and filings in onBeforeMount to ensure fresh data; updated comments for clarity
src/lang/en.json	Added new i18n strings for pending filing messages; fixed typo in "dissolutionSubTypes" key
src/interfaces/filing-i.ts	Reordered interface properties for consistency (displayLedger before displayName)
src/components/bcros/filing/common/filedAnd/Pending.vue	Created new component to display pending filing subtitle with status indicators
src/components/bcros/filing/common/HeaderActions.vue	Added conditional logic to show View/Hide buttons for Court Orders (non-staff) and pending filings
src/components/bcros/filing/CommonTemplate.vue	Added conditional rendering for pending filing body content with appropriate messaging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-03T21:33:29Z

src/stores/filings.ts

    if (!businessCached || force) {
-      filings.value = await getFilings(identifier)
+      const newFilings = await getFilings(identifier)
+      filings.value.push(...newFilings)


The _filingsForIdentifier variable is never updated after loading filings. This means the cache check on line 78 will always fail after the first load, causing loadFilings to repeatedly append new filings instead of replacing them.

After line 81, you should add: _filingsForIdentifier.value = identifier

Suggested change

filings.value.push(...newFilings)

filings.value.push(...newFilings)

_filingsForIdentifier.value = identifier

CP is correct. This looks like unfinished code so I simply cleaned it up.

I also updated the check for "no filings" because filings.value is always True, even when it's first initialized as [] (on line 12).

Re: line 77

This method (loadFilings) is only called for actual businesses (not bootstrap filings), so the history list should always have 1 or more filings. And if, for some reason, it doesn't, then the expression on line 78 will be true and it won't hurt to try to get the new filings again.

Re: line 80

Whether loadFilings is called with an empty list or one with a pending task, the new filings will be added to the end (bottom) of the list, keeping a potential pending task at the top.

Copilot · 2025-12-03T21:33:30Z

src/stores/todo.ts

+          // if this is a "Pending | Payment Completed" maintenance filing task
+          // then insert it into the filings list instead of the todos list
+          if (isPendingPaymentCompletedTask(task) && isMaintenanceFilingTask(task)) {
+            useBcrosFilings().insertFiling(taskAsFiling(task))


Potential null pointer exception: taskAsFiling(task) can return null (see line 84 in the function), but insertFiling expects a non-null ApiResponseFilingI parameter. This could cause a runtime error when trying to insert a null filing.

Consider adding a null check:

const filing = taskAsFiling(task) if (filing) { useBcrosFilings().insertFiling(filing) }

Suggested change

useBcrosFilings().insertFiling(taskAsFiling(task))

const filing = taskAsFiling(task)

if (filing) {

useBcrosFilings().insertFiling(filing)

}

I'm not concerned about this because:

task is an iterable, so won't be null

the checks on line 91 will be false(y) if this isn't the right kind of task, so line 92 won't be executed

src/utils/todo/index.ts

src/stores/filings.ts

severinbeauvais · 2025-12-03T22:10:01Z

src/stores/filings.ts


+  const insertFiling = (filing: ApiResponseFilingI) => {
+    filings.value.unshift(filing)
+  }


Note: whether insertFiling is called before the filings are fetched (list is empty) or after the filings are fetched, it will insert the filing at the start (top) of the list, keeping a potential pending task at the top.

severinbeauvais · 2025-12-03T22:59:56Z

cypress/fixtures/todos/pendingCorrection.json

            "isCorrectionPending": false,
            "name": "correction",
            "priority": false,
-            "paymentStatusCode": "COMPLETED",


A "pending - payment completed" task now displays in the History list, so I simply changed this to "pending - payment incomplete".

Ditto below.

severinbeauvais · 2025-12-03T23:00:43Z

src/components/bcros/filing/CommonTemplate.vue

-              {{ $t('text.filing.general.paidButNotCompletedByRegistry').replace('FILING', title) }}
-            </p>
-
+            <p> {{ $t('text.filing.general.paidButNotCompletedByRegistry', { title }) }} </p>


Note that I used the built-in replacement feature to replace {title} in the string with the title property.

severinbeauvais · 2025-12-03T23:01:52Z

src/components/bcros/filing/common/HeaderActions.vue

        <strong v-if="!isExpanded">{{ $t('button.filing.actions.view') }}</strong>
        <strong v-else>{{ $t('button.filing.actions.hide') }}</strong>
      </template>
+


Below, I thought it was clearer to have separate conditions, even though they all display View/Hide, instead of trying to combine the conditions. Thoughts?

severinbeauvais · 2025-12-03T23:02:43Z

src/components/bcros/filing/common/filedAnd/Pending.vue

+defineProps({
+  filing: { type: Object as PropType<ApiResponseFilingI>, required: true }
+})
+</script>


Looks like this:

severinbeauvais · 2025-12-03T23:03:37Z

src/lang/en.json

        "filingPending": "Filing Pending",
-        "paidButNotCompletedByRegistry": "This FILING is paid, but the filing has not been completed by the Business Registry yet. Some filings may take longer than expected.",
+        "paidButStillBeingProcessed": "This {title} is paid, but is still being processed. Refresh this page or come back later to check on the progress.",
+        "ifThisIssueContinues": "If this issue continues, please contact us.",


Looks like this:

severinbeauvais · 2025-12-03T23:03:54Z

src/lang/en.json

    "correction": "Correction",
    "courtOrder": "Court Order",
    "dissolution": "Dissolution",
-    "dissolutionSybTypes": {


Before (note "This Dissolution is..."):

After (note "This Voluntary Dissolution is..."):

Ref: https://dev.business-dashboard.bcregistry.gov.bc.ca/BC0888391?accountid=3040

severinbeauvais · 2025-12-03T23:23:33Z

src/pages/dashboard.vue


 onBeforeMount(async () => {
+  useBcrosTodos().clearTodos()
+  useBcrosFilings().clearFilings()


This is probably not needed since the the lists are already initialized to [] but I'm adding this here to be explicit and in case this page/component is ever re-mounted.

severinbeauvais · 2025-12-03T23:52:59Z

/gcbrun

bcregistry-sre · 2025-12-03T23:55:27Z

Temporary Url for review: https://business-dashboard-dev--pr-240-t8m3ord0.web.app

SB says, you can look at the screenshots in the tickets or you can try these:

Pending | Payment Incomplete COD: https://business-dashboard-dev--pr-240-t8m3ord0.web.app/BC0888407
Pending | Payment Incomplete Registration: https://business-dashboard-dev--pr-240-t8m3ord0.web.app/TILOIpJ1ad
Pending | Payment Incomplete Amalgamation: https://business-dashboard-dev--pr-240-t8m3ord0.web.app/T4zDYdeil8
Pending | Payment Incomplete Vol Dissolution: https://business-dashboard-dev--pr-240-t8m3ord0.web.app/BC0888391

loneil

Code changes make sense, poked at deployed links a bit and look good I think

severinbeauvais self-assigned this Dec 3, 2025

Copilot AI review requested due to automatic review settings December 3, 2025 21:28

severinbeauvais requested review from Rajandeep98, TVWerdal, ketaki-deodhar and meawong as code owners December 3, 2025 21:28

severinbeauvais requested a review from loneil December 3, 2025 21:29

Copilot started reviewing on behalf of severinbeauvais December 3, 2025 21:29 View session

Copilot finished reviewing on behalf of severinbeauvais December 3, 2025 21:32

Copilot AI reviewed Dec 3, 2025

View reviewed changes

Severin Beauvais added 2 commits December 3, 2025 13:40

- fixed businessCached check

10edfa1

- change "screen" -> "page" (per Jacqueline)

fa2c538

severinbeauvais commented Dec 3, 2025

View reviewed changes

Severin Beauvais added 2 commits December 3, 2025 14:20

- fixed const in composable

950e989

- fixed e2e tests

9ea547b

severinbeauvais commented Dec 3, 2025

View reviewed changes

severinbeauvais force-pushed the 31526 branch from 50a2ded to b14bfb3 Compare December 3, 2025 23:45

- wip

ea416e0

severinbeauvais force-pushed the 31526 branch from b14bfb3 to ea416e0 Compare December 3, 2025 23:52

bcgov deleted a comment from bcregistry-sre Dec 4, 2025

severinbeauvais requested a review from vysakh-menon-aot December 4, 2025 17:18

severinbeauvais changed the title ~~31526 + 31543 Display pending maintenance filings in History instead of To Do~~ 31526 + 31543: Display pending maintenance filings in History instead of To Do + Update Court Order buttons Dec 4, 2025

severinbeauvais changed the title ~~31526 + 31543: Display pending maintenance filings in History instead of To Do + Update Court Order buttons~~ 31526 + 31543: Display pending maintenance filings in History instead of To Do + Update Court Order action buttons Dec 4, 2025

vysakh-menon-aot approved these changes Dec 4, 2025

View reviewed changes

loneil approved these changes Dec 4, 2025

View reviewed changes

Rajandeep98 approved these changes Dec 4, 2025

View reviewed changes

severinbeauvais mentioned this pull request Dec 4, 2025

Business Dashboard - add/update e2e tests for "Pending-Payment Completed" bootstrap vs maintenance filings bcgov/entity#31555

Open

severinbeauvais merged commit fc3c56a into bcgov:main Dec 4, 2025
6 checks passed

severinbeauvais mentioned this pull request Dec 11, 2025

31640 Update version num to 1.1.28 #241

Merged

	filings.value.push(...newFilings)
	filings.value.push(...newFilings)
	_filingsForIdentifier.value = identifier

-            useBcrosFilings().insertFiling(taskAsFiling(task))
+            const filing = taskAsFiling(task)
+            if (filing) {
+              useBcrosFilings().insertFiling(filing)
+            }

31526 + 31543: Display pending maintenance filings in History instead of To Do + Update Court Order action buttons #240

31526 + 31543: Display pending maintenance filings in History instead of To Do + Update Court Order action buttons #240

Uh oh!

Conversation

severinbeauvais commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

severinbeauvais Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

severinbeauvais commented Dec 3, 2025

Uh oh!

bcregistry-sre commented Dec 3, 2025 • edited by severinbeauvais Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

loneil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

severinbeauvais commented Dec 3, 2025 •

edited

Loading

severinbeauvais Dec 3, 2025 •

edited

Loading

severinbeauvais Dec 3, 2025 •

edited

Loading

severinbeauvais Dec 3, 2025 •

edited

Loading

severinbeauvais Dec 3, 2025 •

edited

Loading

bcregistry-sre commented Dec 3, 2025 •

edited by severinbeauvais

Loading