feat: Add officers section to business dashboard UI #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… types to role-type-e.ts- Add officer-related translation strings to language file- Implement officers section in dashboard.vue
hanlunBCRegistries
changed the title
Author
|
/gcbrun |
1 similar comment
Contributor
|
/gcbrun |
Collaborator
|
Temporary Url for review: https://business-dashboard-dev--pr-188-amkjl7u6.web.app |
src/pages/dashboard.vue
Outdated
| } | ||
| const changeOfficerInfo = () => { | ||
| goToFilingsUI(`/${business.currentBusinessIdentifier}/standalone-officers`, { filingId: '0' }) |
Author
There was a problem hiding this comment.
This part is subject to be updated once the add/edit officer change is implemented
Author
|
/gcbrun |
1 similar comment
Contributor
|
/gcbrun |
Collaborator
|
Temporary Url for review: https://business-dashboard-dev--pr-188-amkjl7u6.web.app |
Collaborator
|
This PR is on hold for now -- the current design is to not show Officers on the busines dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: Add Officers Section to Business Dashboard UI
*Issue:*https://github.com/bcgov/entity/issues/
Changes
role-type-e.tsDescription
This PR adds support for displaying business officers in the dashboard UI. The implementation includes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).