Skip to content

Conversation

@CarlyCotton
Copy link
Collaborator

@CarlyCotton CarlyCotton commented Jan 6, 2026

BPMN Changes (25-26 & 26-27)

Added a new assessment flow to accept the approved step parent appeal waivers:
image
In Waived Parent we determine if "parent1" or "parent2" is going to be used based on comparing the supporting user IDs:
image
After that we assign the correct parent's variable to each appealDataParent value and following the same calculation for "Total Parent Eligible Dependants", "Parental Assets", "Parental Contribution" based on the remaining parent. Family size is also no longer including a second parent.
image
This has allowed "Calculate Family Income" to remain the same calculation with or without an appeal and still supports the original income priority (cra > parent report > student report)


E2E Tests

  • Family Size should not change if appeal data doesn't exist
  • Appeal but parent count is only 1 (unhappy path)
  • Appeal but student is not dependant (unhappy path)
  • Appeal applies: reduce family total income & net income, family size, parent dependants.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2026

@CarlyCotton CarlyCotton self-assigned this Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 20.35% ( 4323 / 21244 )
Methods: 9.68% ( 252 / 2603 )
Lines: 24.5% ( 3705 / 15123 )
Branches: 10.4% ( 366 / 3518 )

@CarlyCotton CarlyCotton added the Camunda Worflow Involves camunda workflow changes label Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 75.41% ( 1055 / 1399 )
Methods: 79.31% ( 115 / 145 )
Lines: 78.79% ( 769 / 976 )
Branches: 61.51% ( 171 / 278 )

@CarlyCotton CarlyCotton marked this pull request as draft January 6, 2026 02:32
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 85.68% ( 1616 / 1886 )
Methods: 85% ( 187 / 220 )
Lines: 88.64% ( 1287 / 1452 )
Branches: 66.36% ( 142 / 214 )

@CarlyCotton CarlyCotton changed the title #5418 - Appeal Step-parent waiver assessment #5418 - Appeal Step-parent waiver Assessment Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

E2E SIMS API Coverage Report

Totals Coverage
Statements: 75.5% ( 8548 / 11322 )
Methods: 75.5% ( 1023 / 1355 )
Lines: 79.58% ( 6213 / 7807 )
Branches: 60.74% ( 1312 / 2160 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Camunda Worflow Involves camunda workflow changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants