#5420 - Update Offering View #5563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiago-graf
changed the title
tiago-graf
added
Ministry
weskubo-cgi
requested changes
Dec 29, 2025
sources/packages/backend/apps/api/src/utilities/datatable-config.ts
Outdated
Show resolved
Hide resolved
...ckend/apps/api/src/services/education-program-offering/education-program-offering.service.ts
Outdated
Show resolved
Hide resolved
...tests_/e2e/education-program-offering.institutions.controller.getOfferingSummary.e2e-spec.ts
Show resolved
Hide resolved
...tests_/e2e/education-program-offering.institutions.controller.getOfferingSummary.e2e-spec.ts
Show resolved
Hide resolved
...ckend/apps/api/src/services/education-program-offering/education-program-offering.service.ts
Show resolved
Hide resolved
...tests_/e2e/education-program-offering.institutions.controller.getOfferingSummary.e2e-spec.ts
Outdated
Show resolved
Hide resolved
Collaborator
|
note: Branch name is missing leading # so I couldn't find it at first! |
Collaborator
|
issue: I forgot to mention that the search fields get pretty squished together when they start wrapping at lower resolutions: 
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the offering summary view with enhanced filtering capabilities and UI improvements. The changes introduce new filters for study start date range and intensity, restructure the data table to split study dates into separate columns, and standardize the presentation of intensity and delivery options text.
Key changes:
- Added date range and intensity filters to the offering summary search interface
- Split the combined "Study Dates" column into separate "Study Start Date" and "Study End Date" columns with sorting enabled
- Standardized text formatting for intensity (Full-Time, Part-Time) and delivery options (capitalized)
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
sources/packages/web/src/components/common/OfferingSummary.vue |
Added date range and intensity filters with validation, restructured data table columns, and implemented text formatting helpers |
sources/packages/web/src/components/common/ProgramDetails.vue |
Moved "Add offering" button from OfferingSummary to ProgramDetails header, updated prop naming to kebab-case |
sources/packages/web/src/components/common/ManageProgramAndOfferingSummary.vue |
Refactored offering edit permission logic from OfferingSummary to parent component, updated prop naming to kebab-case |
sources/packages/web/src/types/contracts/DataTableContract.ts |
Split "Study Dates" header into separate start/end date columns and enabled sorting on multiple columns |
sources/packages/backend/apps/api/src/utilities/datatable-config.ts |
Added OfferingPaginationOptions interface with new filter properties for intensity and date range |
sources/packages/backend/apps/api/src/route-controllers/models/pagination.dto.ts |
Extended OfferingsPaginationOptionsAPIInDTO with intensity and date filters, updated sortable fields list |
sources/packages/backend/apps/api/src/services/education-program-offering/education-program-offering.service.ts |
Implemented filtering logic for intensity and study start date range in getAllEducationProgramOffering method |
sources/packages/backend/apps/api/src/route-controllers/education-program-offering/_tests_/e2e/education-program-offering.institutions.controller.getOfferingSummary.e2e-spec.ts |
Added comprehensive e2e tests covering all new filter combinations and edge cases |
sources/packages/web/src/views/institution/locations/program-info-request/LocationProgramInfoRequestSummary.vue |
Added density="compact" to filter toggle button for consistent styling |
sources/packages/web/src/views/institution/locations/confirmation-of-enrollment/COESummaryData.vue |
Added density="compact" to filter toggle button for consistent styling |
sources/packages/web/src/views/aest/institution/InstitutionNotes.vue |
Added density="compact" to toggle button and updated prop naming to kebab-case |
sources/packages/web/src/views/aest/CASInvoices.vue |
Added density="compact" to filter toggle button for consistent styling |
sources/packages/web/src/components/common/notes/StudentNotes.vue |
Added density="compact" to toggle button and updated prop naming to kebab-case |
sources/packages/backend/apps/api/src/route-controllers/models/pagination.dto.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/api/src/utilities/datatable-config.ts
Outdated
Show resolved
Hide resolved
1 task
…Summary.e2e-spec.ts
…Summary.e2e-spec.ts
dheepak-aot
reviewed
Dec 30, 2025
dheepak-aot
reviewed
Dec 30, 2025
...tests_/e2e/education-program-offering.institutions.controller.getOfferingSummary.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 30, 2025
...tests_/e2e/education-program-offering.institutions.controller.getOfferingSummary.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 30, 2025
...tests_/e2e/education-program-offering.institutions.controller.getOfferingSummary.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 31, 2025
...tests_/e2e/education-program-offering.institutions.controller.getOfferingSummary.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 31, 2025
| baseEndpoint = `/institutions/education-program-offering/location/${institutionLocation.id}`; | ||
| }); | ||
|
|
||
| it("Should return all offerings when no filters are applied.", async () => { |
dheepak-aot
reviewed
Dec 31, 2025
dheepak-aot
reviewed
Dec 31, 2025
weskubo-cgi
approved these changes
Jan 1, 2026
Collaborator
weskubo-cgi
left a comment
weskubo-cgi
left a comment
There was a problem hiding this comment.
Approved. There's one minor comment I added to ManageProgramAndOfferingSummary.vue that would be good to get cleaned up.
| setup(props) { | ||
| const { isReadOnlyUser } = useInstitutionAuth(); | ||
| const isProgramEditable = computed( |
Collaborator
There was a problem hiding this comment.
suggestion: This doesn't need to be computed as it's not used in the template.
Collaborator
Author
There was a problem hiding this comment.
it actually caused a bug after I removed the computed, I don't know much about why but I ended up adding it back
…Summary.e2e-spec.ts
…Summary.e2e-spec.ts
dheepak-aot
reviewed
Jan 2, 2026
| props.educationProgram.isExpired || | ||
| AuthService.shared.authClientType === ClientIdType.AEST | ||
| ) { | ||
| if (props.allowEdit) { |
Collaborator
There was a problem hiding this comment.
it should be (!props.allowEdit) as the logic inside if s now a flip condition from past
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
dheepak-aot
approved these changes
Jan 2, 2026
Collaborator
dheepak-aot
left a comment
dheepak-aot
left a comment
There was a problem hiding this comment.
Thanks for making the changes and doing some refactors on the way. Looks good. 👍
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Front End Changes
Offering Summary View updated with new design: Add offering left of Program Actions
Add Filters to Offerings table: Start Study Date Range + Intensity
Data table updated with new design: Split Study Dates column
Fixes standard intensity text (Full-time, Part-time) and delivery options (Onsite, Online)
Back End Changes
Add new filters logic to get offering summary service method.
Add new e2e tests
Refactoring Changes
Updated filter toggle buttons in various views to use
density="compact"for a standard presentation.Screen follows a responsive design based on the ticket example wireframe:
Refactoring example: