Skip to content

PSP-11162: Update and add test cases according to new development #5197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stairaku wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

PSP-11162: Update and add test cases according to new development #5197

stairaku wants to merge 3 commits into from

Conversation

@stairaku
Copy link
Collaborator

@stairaku stairaku commented Feb 9, 2026

No description provided.

@stairaku stairaku self-assigned this Feb 9, 2026
@stairaku stairaku added the test-scripts Tag used for functional test scripts label Feb 9, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 9, 2026
View reviewed changes
testing/PIMS.Tests.Automation/Features/AcquisitionFiles.feature
Scenario: 02._Acquisition_File_Properties
Given I create a new Acquisition File from row number 3
When I add Properties to the Acquisition File
And I verify the Acquisition File Improvements Tab

Check warning

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
String
Loading
- the conversion can be done implicitly.
testing/PIMS.Tests.Automation/Features/AcquisitionFiles.feature
Scenario: 02._Acquisition_File_Properties
Given I create a new Acquisition File from row number 3
When I add Properties to the Acquisition File
And I verify the Acquisition File Improvements Tab

Check warning

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
Table
Loading
- the conversion can be done implicitly.
testing/PIMS.Tests.Automation/Features/Properties.feature
Scenario: 02._Property_Improvements_Tab
Given I review a Property's Information from row number 3
When I create Property Improvements
Then I update Property Improvements from row number 6

Check warning

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
String
Loading
- the conversion can be done implicitly.
testing/PIMS.Tests.Automation/Features/Properties.feature
Scenario: 02._Property_Improvements_Tab
Given I review a Property's Information from row number 3
When I create Property Improvements
Then I update Property Improvements from row number 6

Check warning

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
Table
Loading
- the conversion can be done implicitly.
testing/PIMS.Tests.Automation/Features/Properties.feature
Given I review a Property's Information from row number 3
When I create Property Improvements
Then I update Property Improvements from row number 6
Then A Property Information is saved successfully

Check warning

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
String
Loading
- the conversion can be done implicitly.
testing/PIMS.Tests.Automation/Features/Properties.feature
Given I review a Property's Information from row number 3
When I create Property Improvements
Then I update Property Improvements from row number 6
Then A Property Information is saved successfully

Check warning

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
Table
Loading
- the conversion can be done implicitly.
testing/PIMS.Tests.Automation/Features/Properties.feature
When I create Property Improvements
Then I update Property Improvements from row number 6
Then A Property Information is saved successfully

Check warning

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
String
Loading
- the conversion can be done implicitly.
testing/PIMS.Tests.Automation/Features/Properties.feature
When I create Property Improvements
Then I update Property Improvements from row number 6
Then A Property Information is saved successfully

Check warning

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
Table
Loading
- the conversion can be done implicitly.
testing/PIMS.Tests.Automation/PageObjects/PropertyImprovements.cs

private readonly By licenseImproTotal = By.XPath("//div[@role='tabpanel']/div/div[2]/div");

private SharedModals sharedModals;

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note test

Field 'sharedModals' can be 'readonly'.
asanchezr
asanchezr approved these changes Feb 9, 2026
View reviewed changes
Copy link
Collaborator

@asanchezr asanchezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just need to update the FE snapshots by running:

npm test -- -u

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asanchezr asanchezr asanchezr approved these changes

Assignees

@stairaku stairaku

Labels

test-scripts Tag used for functional test scripts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stairaku @asanchezr