Skip to content

Conversation

@dfilteau
Copy link
Contributor

@dfilteau dfilteau commented Feb 5, 2026

PSP_PIMS | Development Sprint: S117.00 | Design Sprint: 116 | Date: 2026-Feb-05

  • Added tables:
    • PIMS_DISPOSITION_AGREEMENT
    • PIMS_DISPOSITION_AGREEMENT_HIST
    • PIMS_DISPOSITION_AGREEMENT_TYPE
    • PIMS_DISPOSITION_FILE_FORM
    • PIMS_DISPOSITION_FILE_FORM_HIST
    • PIMS_DISPOSITION_FORM_TYPE
    • PIMS_DSP_AGREEMENT_STATUS_TYPE
  • Altered tables:
    • PIMS_DSP_CHKLST_ITEM_TYPE
    • PIMS_PROPERTY_IMPROVEMENT
    • PIMS_PROPERTY_IMPROVEMENT_HIST
  • Altered views:
    • PIMS_PROPERTY_LITE_VW
  • Altered stored proedures:
    • PIM_DELETION_HISTORY
  • Altered user-defined functions:
    • PIM_GET_COLUMN_LIST
    • PIM_GET_PK_COLUMN
  • Added seed scripts:
    • 172_DML_PIMS_PROP_IMPRVMNT_STATUS_TYPE.sql
    • 173_DML_PIMS_DISPOSITION_AGREEMENT_TYPE.sql
    • 174_DML_PIMS_DSP_AGREEMENT_STATUS_TYPE.sql
  • Altered seed scripts:
    • 109_DML_PIMS_LEASE_STAKEHOLDER_TYPE.sql
    • 123_DML_PIMS_FORM_TYPE.sql
    • 124_DML_PIMS_AGREEMENT_TYPE.sql
    • 140_DML_PIMS_DISPOSITION_TYPE
    • 147_DML_PIMS_DSP_CHKLST_SECTION_TYPE.sql
    • 148_DML_PIMS_DSP_CHKLST_ITEM_TYPE.sql
  • Added test scripts:
    • 131_PIMS_NOTICE_OF_CLAIM.sql
    • 132_PIMS_DISPOSITION_FORM_TYPE.sql
    • 133_PIMS_DISPOSITION_FILE_FORM.sql
    • 134_PIMS_DISPOSITION_AGREEMENT.sql
    • 135_PIMS_PROPERTY_DOCUMENT.sql
    • 136_PIMS_DISPOSITION_AGREEMENT.sql
  • Altered test scripts:
    • 011_PIMS_PROPERTY_IMPROVEMENT_TEST_DATA.sql

PSP_PIMS | Development Sprint: S117.00 | Design Sprint: 116 | Date: 2026-Feb-05
- Added tables:
  - PIMS_DISPOSITION_AGREEMENT
  - PIMS_DISPOSITION_AGREEMENT_HIST
  - PIMS_DISPOSITION_AGREEMENT_TYPE
  - PIMS_DISPOSITION_FILE_FORM
  - PIMS_DISPOSITION_FILE_FORM_HIST
  - PIMS_DISPOSITION_FORM_TYPE
  - PIMS_DSP_AGREEMENT_STATUS_TYPE
- Altered tables:
  - PIMS_DSP_CHKLST_ITEM_TYPE
  - PIMS_PROPERTY_IMPROVEMENT
  - PIMS_PROPERTY_IMPROVEMENT_HIST
- Altered views:
  - PIMS_PROPERTY_LITE_VW
- Altered stored proedures:
  - PIM_DELETION_HISTORY
- Altered user-defined functions:
  - PIM_GET_COLUMN_LIST
  - PIM_GET_PK_COLUMN
- Added seed scripts:
  - 172_DML_PIMS_PROP_IMPRVMNT_STATUS_TYPE.sql
  - 173_DML_PIMS_DISPOSITION_AGREEMENT_TYPE.sql
  - 174_DML_PIMS_DSP_AGREEMENT_STATUS_TYPE.sql
- Altered seed scripts:
  - 109_DML_PIMS_LEASE_STAKEHOLDER_TYPE.sql
  - 123_DML_PIMS_FORM_TYPE.sql
  - 124_DML_PIMS_AGREEMENT_TYPE.sql
  - 140_DML_PIMS_DISPOSITION_TYPE
  - 147_DML_PIMS_DSP_CHKLST_SECTION_TYPE.sql
  - 148_DML_PIMS_DSP_CHKLST_ITEM_TYPE.sql
- Added test scripts:
  - 131_PIMS_NOTICE_OF_CLAIM.sql
  - 132_PIMS_DISPOSITION_FORM_TYPE.sql
  - 133_PIMS_DISPOSITION_FILE_FORM.sql
  - 134_PIMS_DISPOSITION_AGREEMENT.sql
  - 135_PIMS_PROPERTY_DOCUMENT.sql
  - 136_PIMS_DISPOSITION_AGREEMENT.sql
- Altered test scripts:
  - 011_PIMS_PROPERTY_IMPROVEMENT_TEST_DATA.sql
@eddherrera eddherrera self-assigned this Feb 5, 2026
dfilteau and others added 4 commits February 6, 2026 15:43
Removed default values on:
- PIMS_DSP_AGREEMENT_STATUS_TYPE.IS_DISABLED
- PIMS_DISPOSITION_AGREEMENT_TYPE.IS_DISABLED
Changed to NOT NULL
- PIMS_DSP_AGREEMENT_STATUS_TYPE.IS_DISABLED
- PIMS_DISPOSITION_AGREEMENT_TYPE.IS_DISABLED
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
83.4% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@eddherrera eddherrera added this pull request to the merge queue Feb 9, 2026
Merged via the queue into bcgov:dev with commit 6ff02dd Feb 9, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants