-
Notifications
You must be signed in to change notification settings - Fork 26
psp-10863 | Cleaned up FeatureDataset object and refactored dependant code #5113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…le property selector and refactor code to use it
| import { IResponseWrapper } from '@/hooks/util/useApiRequestWrapper'; | ||
| import { ApiGen_Concepts_PropertyOperation } from '@/models/api/generated/ApiGen_Concepts_PropertyOperation'; | ||
| import { AxiosResponse } from 'axios'; | ||
| import { ApiGen_Concepts_File } from '@/models/api/generated/ApiGen_Concepts_File'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
| import { ApiGen_Concepts_PropertyOperation } from '@/models/api/generated/ApiGen_Concepts_PropertyOperation'; | ||
| import { AxiosResponse } from 'axios'; | ||
| import { ApiGen_Concepts_File } from '@/models/api/generated/ApiGen_Concepts_File'; | ||
| import { FileForm, PropertyForm } from '../shared/models'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
| import { PropertyForm } from '../shared/models'; | ||
| import ManagementContainer, { IManagementContainerProps } from './ManagementContainer'; | ||
| import { IManagementViewProps } from './ManagementView'; | ||
| import ManagementForm from './form/ManagementForm'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
|
|
||
| import { FileForm, PropertyForm, WithFormProperties } from '../../models'; | ||
| import PropertiesListContainer from './PropertiesListContainer'; | ||
| import { PIMS_Property_Location_View } from '@/models/layers/pimsPropertyLocationView'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
| import UpdatePropertiesContainer, { | ||
| IUpdatePropertiesContainerProps, | ||
| } from './UpdatePropertiesContainer'; | ||
| import { IPropertiesListContainerProps } from './PropertiesListContainer'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
| import React from 'react'; | ||
| import { FormikProps, getIn } from 'formik'; | ||
| import { PropertyForm, WithFormProperties } from '../../models'; | ||
| import { map } from 'lodash'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
| import { WorklistContainer } from './WorklistContainer'; | ||
| import { IWorklistViewProps } from './WorklistView'; | ||
| import { ParcelDataset } from '../parcelList/models'; | ||
| import { LocationFeatureDataset } from '@/components/common/mapFSM/useLocationFeatureLoader'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
|
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5113 |




Removed repeated models similar to FeatureDataSet and improved inheritance
Cleaned components and refactor the use of PropertyForm and FeatureDataset
Refactored Property selection to have a clear separation of concerns
Standarized creation for files and the use of the property display
Cleaned up Map FSM to use only the data in requires