Conversation
- Updated Dockerfile to use Debian 11-slim and install additional dependencies. - Removed unused gmock-install.sh script. - Adapt test cases to ensure comparison of chrono seconds. - Updated dummy-brightnessd.py to use GLib instead of gobject. - Adapt test.pri to include necessary libraries for testing.
mbraendli
force-pushed
the
feat/expand-for-imx8-board
branch
3 times, most recently
from
4de35fb to
7a83f01
Compare
beat-schaer
approved these changes
Nov 12, 2025
| @@ -36,6 +36,7 @@ Thumbs.db | |||
| /.qmake.stash | |||
| build-*-Debug/ | |||
Collaborator
There was a problem hiding this comment.
Sind die Ignore-Einträge für Debug und Release dann immer noch notwendig?
Collaborator
Author
There was a problem hiding this comment.
Das Projekt ist für den Qt-Creator ausgelegt und dieser kreiert Ordner mit diesen Namen.
Collaborator
There was a problem hiding this comment.
Fehlen da nicht noch Einträge für
- Configuration.h / .cpp
- PowersaveProxy.h / .cpp
Collaborator
Author
There was a problem hiding this comment.
Im common.test.pro nicht, da es keine Teste dazu gibt, aber habe nun noch eine common Lib eingeführt.
fbactivityd/FramebufferIdle.cpp
Outdated
| stop(); | ||
|
|
||
| // Clean up devices | ||
| qDeleteAll(m_devices); |
Collaborator
There was a problem hiding this comment.
Wäre von mir aus gesehen nicht notwendig, weil die Devices über den Parent eh verbunden sind und damit beim Zerstören gelöscht werden würden.
Collaborator
Author
There was a problem hiding this comment.
Habe ich entfernt.
mbraendli
force-pushed
the
feat/expand-for-imx8-board
branch
from
7a83f01 to
827c3c0
Compare
mbraendli
force-pushed
the
feat/expand-for-imx8-board
branch
from
827c3c0 to
f9c5b08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.