Cleanup

.clang-format

@@ -1,5 +1,4 @@
 ---
-Language: Cpp
 # BasedOnStyle:  LLVM
 AccessModifierOffset: -2
 AlignAfterOpenBracket: Align

.cmake-format.yaml

@@ -1,92 +1,10 @@
 ---
 parse:
     additional_commands:
-        _add_layer_library:
-            pargs: 2+
-            kwargs:
-                FORBIDDEN: '*'
-                LINK_LIBS:
-                    kwargs:
-                        PUBLIC: '*'
-                        PRIVATE: '*'
-                INCLUDE_DIRS:
-                    kwargs:
-                        PUBLIC: '*'
-                        PRIVATE: '*'
-        add_infrastructure_library:
-            pargs: 2+
-            kwargs:
-                LINK_LIBS:
-                    kwargs:
-                        PUBLIC: '*'
-                        PRIVATE: '*'
-                INCLUDE_DIRS:
-                    kwargs:
-                        PUBLIC: '*'
-                        PRIVATE: '*'
-        add_application_library:
-            pargs: 2+
-            kwargs:
-                LINK_LIBS:
-                    kwargs:
-                        PUBLIC: '*'
-                        PRIVATE: '*'
-                INCLUDE_DIRS:
-                    kwargs:
-                        PUBLIC: '*'
-                        PRIVATE: '*'
-        add_domain_library:
-            pargs: 2+
-            kwargs:
-                LINK_LIBS:
-                    kwargs:
-                        PUBLIC: '*'
-                        PRIVATE: '*'
-                INCLUDE_DIRS:
-                    kwargs:
-                        PUBLIC: '*'
-                        PRIVATE: '*'
-        add_libs_library:
-            pargs: 2+
-            kwargs:
-                LINK_LIBS:
-                    kwargs:
-                        PUBLIC: '*'
-                        PRIVATE: '*'
-                INCLUDE_DIRS:
-                    kwargs:
-                        PUBLIC: '*'
-                        PRIVATE: '*'
-        add_utils_library:
-            pargs: 2+
-            kwargs:
-                LINK_LIBS:
-                    kwargs:
-                        PUBLIC: '*'
-                        PRIVATE: '*'
-                INCLUDE_DIRS:
-                    kwargs:
-                        PUBLIC: '*'
-                        PRIVATE: '*'
-        add_mock_library:
-            pargs: 2+
-            kwargs:
-                MOCKS: '*'
-        add_interface_library:
-            pargs: 2
         enable_coverage:
             pargs: 1
         enable_doxygen:
             pargs: 1
-        generate_arc42_documentation:
-            pargs: 1
-        add_unit_test:
-            pargs: 2+
-            kwargs:
-                LINK_LIBS:
-                    kwargs:
-                        PUBLIC: '*'
-                        PRIVATE: '*'
         enable_sanitizers:
             pargs: 1
         enable_static_analysis:

.devcontainer/Dockerfile

@@ -12,20 +12,11 @@ RUN apt-get update \
     && apt-get -qq install -y --no-install-recommends \
     make \
     build-essential \
-    ninja-build \
     cmake \
-    ccache \
-    clang-18 \
-    clang-tidy-18 \
-    clang-format-18 \
-    clangd-18 \
     dpkg \
     pkg-config \
-    doxygen  \
-    lcov \
     git \
     python3-full \
-    gcc-14 \
     file \
     ssh-client \
     && apt-get clean \

.devcontainer/devcontainer.json

@@ -1,56 +1,60 @@
 {
-    "name": "C++ noVNC",
-    "build": {
-        "context": "..",
-        "dockerfile": "Dockerfile",
-        "args": {
-            "CLANG_VERSION": "19",
-            "GCC_VERSION": "14",
-            "BASE_IMAGE": "mcr.microsoft.com/devcontainers/base:ubuntu"
-        }
-    },
-    "mounts": [
-        "source=${localEnv:HOME}/.ssh,target=/home/vscode/.ssh,type=bind"
-    ],
-    "workspaceMount": "source=${localWorkspaceFolder},target=/workspaces/Coronan,type=bind",
-    "updateRemoteUserUID": true,
-    "postStartCommand": "git config --global --add safe.directory ${containerWorkspaceFolder}",
-    "postAttachCommand": "pre-commit install -f --hook-type pre-commit && conan profile detect --force",
-    "customizations": {
-        "vscode": {
-            "extensions": [
-                "ms-vscode.cpptools",
-                "ms-vscode.cpptools-extension-pack",
-                "ms-vscode.cmake-tools",
-                "xaver.clang-format",
-                "ms-python.python",
-                "ms-python.autopep8",
-                "jeff-hykin.better-cpp-syntax",
-                "matepek.vscode-catch2-test-adapter",
-                "mhutchie.git-graph",
-                "cs128.cs128-clang-tidy",
-                "donjayamanne.githistory",
-                "webfreak.debug",
-                "jnoortheen.nix-ide",
-                "hbenl.vscode-test-explorer",
-                "ms-azuretools.vscode-docker",
-                "actboy168.tasks",
-                "streetsidesoftware.code-spell-checker",
-                "github.vscode-pull-request-github"
-            ]
-        }
-    },
-    "features": {
-        "ghcr.io/devcontainers/features/nix:1": {},
-        "ghcr.io/ChristopherMacGown/devcontainer-features/direnv:1": {}
-    },
-    "forwardPorts": [
-        6080
-    ],
-    "portsAttributes": {
-        "6080": {
-            "label": "noVNC",
-            "onAutoForward": "openPreview"
-        }
+  "name": "C++ noVNC",
+  "build": {
+    "context": "..",
+    "dockerfile": "Dockerfile",
+    "args": {
+      "CLANG_VERSION": "19",
+      "GCC_VERSION": "14",
+      "BASE_IMAGE": "mcr.microsoft.com/devcontainers/base:ubuntu"
     }
+  },
+  "mounts": [
+    "source=${localEnv:HOME}/.ssh,target=/home/vscode/.ssh,type=bind"
+  ],
+  "workspaceMount": "source=${localWorkspaceFolder},target=/workspaces/Coronan,type=bind",
+  "updateRemoteUserUID": true,
+  "postStartCommand": "git config --global --add safe.directory ${containerWorkspaceFolder}",
+  "postAttachCommand": "pre-commit install -f --hook-type pre-commit && conan profile detect --force",
+  "containerEnv": {
+    "DISPLAY": ":0"
+  },
+  "customizations": {
+    "vscode": {
+      "extensions": [
+        "ms-vscode.cpptools",
+        "ms-vscode.cpptools-extension-pack",
+        "ms-vscode.cmake-tools",
+        "xaver.clang-format",
+        "ms-python.python",
+        "ms-python.autopep8",
+        "jeff-hykin.better-cpp-syntax",
+        "matepek.vscode-catch2-test-adapter",
+        "mhutchie.git-graph",
+        "cs128.cs128-clang-tidy",
+        "donjayamanne.githistory",
+        "webfreak.debug",
+        "jnoortheen.nix-ide",
+        "hbenl.vscode-test-explorer",
+        "ms-azuretools.vscode-docker",
+        "actboy168.tasks",
+        "streetsidesoftware.code-spell-checker",
+        "github.vscode-pull-request-github"
+      ]
+    }
+  },
+  "features": {
+    "ghcr.io/devcontainers/features/nix:1": {},
+    "ghcr.io/ChristopherMacGown/devcontainer-features/direnv:1": {}
+  },
+  "forwardPorts": [
+    5901,
+    6080
+  ],
+  "portsAttributes": {
+    "6080": {
+      "label": "noVNC",
+      "onAutoForward": "openPreview"
+    }
+  }
 }

.github/workflows/ci-linux-sanatizer.yml → .github/workflows/ci-linux-sanitizer.yml

@@ -1,5 +1,5 @@
 ---
-name: Linux Sanatizer Builds
+name: Linux Sanitizer Builds
 
 on:
     push:

.github/workflows/ci-macos.yml

@@ -16,13 +16,6 @@ jobs:
             fail-fast: false
             matrix:
                 include:
-                    - name: macOS-13-clang
-                      os: macOS-13
-                      build_type: Release
-                      cppcompiler: clang++
-                      ccompiler: clang
-                      libcxx: libc++
-                      generators: Ninja
                     - name: macOS-15-intel-clang
                       os: macos-15-intel
                       build_type: Release
@@ -83,6 +76,8 @@ jobs:
             - name: CTest
               run: ctest -C Debug
               working-directory: ./build
+            - name: CMake build docs
+              run: cmake --build ./build --target doxygen-docs --config ${{ matrix.build_type }}
             - name: CMake build packages
               run: |
                   cpack

.markdownlint.yaml

@@ -0,0 +1,9 @@
+---
+# Disable first-line-heading
+MD041: false
+# Disable line checking
+MD013: false
+# Disable checking for the multiple headings with the same content.
+MD024: false
+# Allow inline HTML, useful for positioning images.
+MD033: false

.pre-commit-config.yaml

@@ -4,31 +4,78 @@ repos:
       rev: v6.0.0
       hooks:
           - id: check-added-large-files
+            stages: [pre-commit]
           - id: check-case-conflict
+            stages: [pre-commit]
           - id: check-merge-conflict
+            stages: [pre-commit]
           - id: check-symlinks
+            stages: [pre-commit]
           - id: check-yaml
+            stages: [pre-commit]
           - id: check-json
+            stages: [pre-commit]
           - id: check-toml
+            stages: [pre-commit]
           - id: check-executables-have-shebangs
+            stages: [pre-commit]
+          - id: check-shebang-scripts-are-executable
+            stages: [pre-commit]
           - id: end-of-file-fixer
+            stages: [pre-commit]
           - id: mixed-line-ending
+            stages: [pre-commit]
           - id: trailing-whitespace
-    - repo: https://github.com/pocc/pre-commit-hooks
-      rev: v1.3.5
+            stages: [pre-commit]
+            args: [--markdown-linebreak-ext=md]
+          - id: detect-private-key
+            stages: [pre-commit]
+    - repo: https://github.com/pre-commit/mirrors-clang-format
+      rev: v22.1.0
       hooks:
           - id: clang-format
-            args: [--style=file, -i]
+            stages: [pre-commit]
     - repo: https://github.com/iconmaster5326/cmake-format-pre-commit-hook
       rev: v0.6.13
       hooks:
           - id: cmake-format
+            stages: [pre-commit]
     - repo: https://github.com/adrienverge/yamllint.git
       rev: v1.37.1
       hooks:
           - id: yamllint
+            stages: [pre-commit]
             args: [--format, parsable, -d, relaxed]
     - repo: https://github.com/jumanjihouse/pre-commit-hook-yamlfmt
       rev: 0.2.3
       hooks:
           - id: yamlfmt
+            stages: [pre-commit]
+        # typos uses typos.toml to find and fix typos
+    - repo: https://github.com/crate-ci/typos
+      rev: v1.44.0
+      hooks:
+          - id: typos
+            stages: [pre-commit]
+    - repo: https://github.com/shellcheck-py/shellcheck-py
+      rev: v0.11.0.1
+      hooks:
+          - id: shellcheck
+            stages: [pre-commit]
+            exclude: \.envrc
+            args: [--severity=warning]
+    - repo: https://github.com/scop/pre-commit-shfmt
+      rev: v3.12.0-2
+      hooks:
+          - id: shfmt
+            stages: [pre-commit]
+            args: [--indent=4, --simplify, --write]
+    # markdownlint-cli uses .markdownlint.yaml to lint markdown files
+    - repo: https://github.com/igorshubovych/markdownlint-cli
+      rev: v0.48.0
+      hooks:
+          - id: markdownlint-docker
+            stages: [pre-commit]
+            args: [--fix]
+
+default_install_hook_types: [pre-commit]

.vscode/c_cpp_properties.json

@@ -1,18 +1,18 @@
 {
-    "configurations": [
-        {
-            "name": "Linux",
-            "includePath": [
-                "${workspaceFolder}/**"
-            ],
-            "defines": [],
-            "compilerPath": "/usr/bin/clang",
-            "cStandard": "c17",
-            "cppStandard": "c++17",
-            "intelliSenseMode": "linux-clang-x64",
-            "compileCommands": "${workspaceFolder}/build/compile_commands.json",
-            "configurationProvider": "ms-vscode.cmake-tools"
-        }
-    ],
-    "version": 4
+  "configurations": [
+    {
+      "name": "Linux",
+      "includePath": [
+        "${workspaceFolder}/**"
+      ],
+      "defines": [],
+      "compilerPath": "/usr/bin/clang",
+      "cStandard": "c17",
+      "cppStandard": "c++17",
+      "intelliSenseMode": "linux-clang-x64",
+      "compileCommands": "${workspaceFolder}/build/compile_commands.json",
+      "configurationProvider": "ms-vscode.cmake-tools"
+    }
+  ],
+  "version": 4
 }