feat: ✨ pass additional pathspec with action arguments#9
Open
akaguny wants to merge 1 commit intobbugh:masterfrom
Open
feat: ✨ pass additional pathspec with action arguments#9akaguny wants to merge 1 commit intobbugh:masterfrom
akaguny wants to merge 1 commit intobbugh:masterfrom
Conversation
Owner
|
Hey @akaguny! Thanks for the PR, I can see how this could be useful in some circumstances. However, it looks like the implementation only allows a single pathspec, which constrains the value of it too much for me to accept as-is to main. If you update it to allow multiple space-separated values then that would be acceptable. I believe the only change needed to support multiple path specs is to expand - -- ":^.github" "${pathspec}")
+ -- ":^.github" ${pathspec[@]}but you'll need to do a bit of testing to make sure that folders with spaces and strings with quotes makes it through, because shell escaping and quoting is so fraught with issues and yaml strings are so loosey-goosey. Let me know if you have any questions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #7
Testing:
expected:

only file-with-fixme-that-throw will throw Error
actual:
👌only file-with-fixme-that-throw will throw Error
https://github.com/akaguny/test-action-fixme-check/actions/runs/6989397876/job/19017976882
notes (for next devs maybe =) ):