Open
Conversation
added 5 commits
March 21, 2012 20:47
During nose install a lot of dead links are scanned each time without this patch.
Collaborator
|
I added some comments on the commits. Basically, the patch needs some work before it can be merged. Especially ponty@8bd3655 looks very dangerous. The goal is good, but the implementation looks dangerous to me. |
Collaborator
|
Btw, this is one of the first times I'm using github to comment on commits. Wow, that works well. I can even pinpoint individual lines! Just being happy with github. Nothing to do with the pull request itself :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was very slow to install nose using tox because a lot of dead links were scanned each time.
I store dead links in cache as empty files so it is faster now. (8bd3655)
Additional changes: logging, more config options, new start method