Open
Conversation
The original diagrams were created with a tool that is not available on all platforms. This change moves to GitHub's built in diagramming features which are universally available and may be better tracked in version control.
…r Flows, and preference for mono-essence.
…ated multi-essence Flows
Contributor
GeorginaShippey
left a comment
GeorginaShippey
left a comment
There was a problem hiding this comment.
Largely very happy with this :D
| These Media Objects are typically short (on the order of seconds) and independently decodable to allow for efficient random access of content. | ||
| Media Objects are mapped to a Flow's timeline via Flow Segments. | ||
| Once the media is in the store, it is considered immutable and never modified directly. | ||
| It's `Flow ID` and relationship to the timeline never changes, ensuring that when you request a particular `Flow ID` and timerange via the API, you always get the same media Segments back. |
Contributor
There was a problem hiding this comment.
I don't really like media Segments here, feels like mashing Media Objects and Flow Segments together. Either I'd go with 'you always get the same media back' or 'you always get the same Flow Segments back'.
Contributor
Author
There was a problem hiding this comment.
I've re-worded this, as I didn't really like how line's 24 and 25 read in the context of Object-reuse. Hopefully thats better.
|
|
||
|  | ||
| > [!NOTE] | ||
| > Mono-essence `Flows` are often still be useful for conveying the technical properties of the tracks within the multiplex stream. |
Contributor
There was a problem hiding this comment.
This sentence doesn't quite make sense. Do you think there could be need for another little ADR in the future where we explore multipexed data storage?
Contributor
Author
There was a problem hiding this comment.
I've tweaked this note-block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR updates AppNote0001 in the following ways:
Jira Issue (if relevant)
Jira URL: https://jira.dev.bbc.co.uk/browse/CLOUDFIT-5510
Related PRs
Where appropriate. Indicate order to be merged.
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.