Open
Conversation
11 tasks
j616
force-pushed
the
jamessa-timeouts
branch
from
18bdf97 to
4fae34a
Compare
j616
force-pushed
the
jamessa-timeouts
branch
from
4fae34a to
0db17d8
Compare
j616
force-pushed
the
jamessa-timeouts
branch
from
0db17d8 to
a4ae4d8
Compare
j616
force-pushed
the
jamessa-timeouts
branch
from
a4ae4d8 to
4fb8f8c
Compare
samdbmg
reviewed
Feb 10, 2026
Member
samdbmg
left a comment
samdbmg
left a comment
There was a problem hiding this comment.
LGTM overall - I think 1sec is too short though!
Co-authored-by: Sam Mesterton-Gibbons <sam.mesterton-gibbons@bbc.co.uk>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR adds proposals for how to signal timeouts on unused Media Objects, and pre-signed URLs.
Jira Issue (if relevant)
Jira URL: https://jira.dev.bbc.co.uk/browse/CLOUDFIT-5512
Related PRs
The contents of this ADR were originally created as part of #157 . Please see the comments on that PR for further discussion on the topic.
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.