Make label mandatory when registering uncontrolled Object Instances#155
Merged
Make label mandatory when registering uncontrolled Object Instances#155
label mandatory when registering uncontrolled Object Instances#155Conversation
samdbmg
approved these changes
Oct 14, 2025
Member
samdbmg
left a comment
There was a problem hiding this comment.
LGTM - couple of docs ideas and nits inlined
sem-ver: api-break
Co-authored-by: Sam Mesterton-Gibbons <sam.mesterton-gibbons@bbc.co.uk>
8210494 to
8a8eae6
Compare
635f4e7 to
5659e5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Makes
labelmandatory when registering uncontrolled Object Instances. This prevents the creation of Object Instances that have no defined mechanisms for modification/deletion.Jira Issue (if relevant)
Jira URL: https://jira.dev.bbc.co.uk/browse/CLOUDFIT-5492
Related PRs
This PR was created following feedback on #144
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.