Plug up all non-void functions without return statements #182
Open
KungFuFurby wants to merge 2 commits intobazz1tv:masterfrom
Open
Plug up all non-void functions without return statements #182KungFuFurby wants to merge 2 commits intobazz1tv:masterfrom
KungFuFurby wants to merge 2 commits intobazz1tv:masterfrom
Conversation
Only a void function is allowed to have a return statement: otherwise, the warning can prove to be fatal post-compilation as the routine runs past the end of the code into some other undefined territory. This commit should resolve every single instance of the warning "control may reach end of non-void function" (whether it always/sometimes does so or not). This commit references bazz1tv#32.
In the process of cherry picking and updating the previous commit, a few others were discovered to have slipped by upon testing the compilation with the latest public version, 0.2.2. This has been corrected. This commit mentions bazz1tv#32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #125. However, the focus here is more narrow.
Only a void function is allowed to have a return statement: otherwise, the warning can prove to be fatal post-compilation as the routine runs past the end of the code into some other undefined territory.
This commit should resolve every single instance of the warning "control may reach end of non-void function" (whether it always/sometimes does so or not).
These days the warning in question is known as "non-void function does not return a value", or "non-void function should return a value", depending on the context.
This merge request references #32.