This repository was archived by the owner on Nov 18, 2025. It is now read-only.
Feature: Kotlin Support #409
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset adds support for running tests written in Kotlin, via the same mechanism used to run Scala tests. The README is also updated with a test sample, and there is a unit test alongside `WebTestTest.java`, but written in Kotlin.
This PR fixes and closes bazelbuild#407, wherein, the build breaks because it references a `rules_scala` version that accesses Maven Central via HTTP. After late Jan 2020, HTTP is no longer allowed on Maven Central, so it produces a build error for anyone who doesn't have the artifact cached already. The only change is upgrading `rules_scala` to the latest `HEAD`, which at this time is bazel-contrib/rules_scala@d2e7e3b.
Contributor
Author
|
fyi this had to include #408 (Scala HTTP fix) to pass CI. the other errors seem to be either transient, or related to Kotlin not supporting Windows for Bazel yet? |
sgammon
added a commit
to sgammon/elide-archive
that referenced
this pull request
Jan 28, 2020
This changeset adds basic initial support for Micronaut, with new
rule macros which inject dependencies, and support for a basic
testbed which works.
Changes so far:
- [x] Add Micronaut dependencies
- [x] Add rule macros for Micronaut libs/apps/etc.
- [x] Add a little testbed which executes controllers
- [x] Add tests for Kotlin and Java
- [x] Invoke Micronaut from a browser test
- [x] From Java
- [x] From Kotlin (this required a patch at
bazelbuild/rules_webtesting#409)
- [x] Ability to opt-out of Micronaut dependencies
8 tasks
sgammon
added a commit
to sgammon/elide-archive
that referenced
this pull request
Jan 28, 2020
This changeset adds basic initial support for Micronaut, with new
rule macros which inject dependencies, and support for a basic
testbed which works.
Changes so far:
- [x] Add Micronaut dependencies
- [x] Add rule macros for Micronaut libs/apps/etc.
- [x] Add a little testbed which executes controllers
- [x] Add tests for Kotlin and Java
- [x] Invoke Micronaut from a browser test
- [x] From Java
- [x] From Kotlin (this required a patch at
bazelbuild/rules_webtesting#409)
- [x] Ability to opt-out of Micronaut dependencies
sgammon
added a commit
to sgammon/elide-archive
that referenced
this pull request
Jan 28, 2020
This changeset adds basic initial support for Micronaut, with new
rule macros which inject dependencies, and support for a basic
testbed which works.
Changes so far:
- [x] Add Micronaut dependencies
- [x] Add rule macros for Micronaut libs/apps/etc.
- [x] Add a little testbed which executes controllers
- [x] Add tests for Kotlin and Java
- [x] Invoke Micronaut from a browser test
- [x] From Java
- [x] From Kotlin (this required a patch at
bazelbuild/rules_webtesting#409)
- [x] Ability to opt-out of Micronaut dependencies
sgammon
added a commit
to sgammon/elide-archive
that referenced
this pull request
Jan 28, 2020
* Feature: Micronaut Support
This changeset adds basic initial support for Micronaut, with new
rule macros which inject dependencies, and support for a basic
testbed which works.
Changes so far:
- [x] Add Micronaut dependencies
- [x] Add rule macros for Micronaut libs/apps/etc.
- [x] Add a little testbed which executes controllers
- [x] Add tests for Kotlin and Java
- [x] Invoke Micronaut from a browser test
- [x] From Java
- [x] From Kotlin (this required a patch at
bazelbuild/rules_webtesting#409)
- [x] Ability to opt-out of Micronaut dependencies
* Activate RBC locally and in CI
* Spawn locally in CI
* Use file-based service key in CI
* Add Redis dependency and CI support
* Add cache support back to CI
* Remove github cache: remote caching is working
* Update Skylib to latest
* Add Stardoc dependency
* Major build refactors, initial support for Starlark docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds support for running tests written in Kotlin, via the same mechanism used to run Scala tests. The README is also updated with a test sample, and there is a unit test alongside
WebTestTest.java, but written in Kotlin.