Modify template for generated toolchain to be more buildifier compliant #596
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are situations where the user might want to reuse the generated file for creating their own toolchain. Making it as much buildifier compliant as possible, it helps for later to see the differences if needed. It is not always possible or easy to make sure that the generated file is buildifier compliant. However, there are some changes that are quite easy to apply. This commit apply some of these changes.
limdor
requested review from
armandomontanez,
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
armandomontanez
approved these changes
Feb 9, 2026
armandomontanez
added
P3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are situations where the user might want to reuse the generated file for creating their own toolchain.
Making it as much buildifier compliant as possible, it helps for later to see the differences if needed.
It is not always possible or easy to make sure that the generated file is buildifier compliant. However, there are some changes that are quite easy to apply. This commit apply some of these changes.