Remove dead code for generation of module map used for Swift compilation#587
Open
jschear wants to merge 1 commit intobazelbuild:mainfrom
Open
Remove dead code for generation of module map used for Swift compilation#587jschear wants to merge 1 commit intobazelbuild:mainfrom
jschear wants to merge 1 commit intobazelbuild:mainfrom
Conversation
jschear
requested review from
armandomontanez,
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
objc_libraryused to generate a clang module map for Swift consumers, but that has been moved intorules_swift's swift_clang_module_aspect.No callers of
compilation_support.register_compile_and_archive_actionswere passinggenerate_module_map_for_swift = True, and I believe this is private API, so it should be safe to remove.