Add missing DEPS_SCANNER_OUTPUT_FILE env entry for msvc toolchain#579
Open
zaucy wants to merge 1 commit intobazelbuild:mainfrom
Open
Add missing DEPS_SCANNER_OUTPUT_FILE env entry for msvc toolchain#579zaucy wants to merge 1 commit intobazelbuild:mainfrom
zaucy wants to merge 1 commit intobazelbuild:mainfrom
Conversation
zaucy
requested review from
armandomontanez,
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
Collaborator
Contributor
Author
|
FYI @PikachuHyA your example here https://github.com/PikachuHyA/bazel_cxx20_modules_demo does not compile without this change when using msvc. |
Contributor
Sorry for the confusion. The GCC/MSVC compatibility code hasn’t been merged into Bazel 9 yet.
Thanks for the heads-up and for your work on this. I’ll take a look and verify it on MSVC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks to have been missed in #428 for msvc