Open
Conversation
This API allows creating shared libraries with custom filenames, not just the default pattern. This is required to write a rule that produces python native extensions which have entirely different output naming formats than standard shared libraries. This API has been around for years now so I assume it's well understood enough and there isn't a clear alternative.
5c8833c to
33603d6
Compare
Member
Author
|
@trybka can you take a look at this one? This is what I was mentioning recently |
Collaborator
|
I'm inclined to approve this, but I am just soliciting one round of internal discussion to see if I get significant push back. From my POV, callers use this all the time, they just use weird hacks to get around the allowlist. We might as well accept Hyrum's law and this is just part of our API. From a pure API standpoint it makes sense to me to say, "you can set the output name" (just as you would with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API allows creating shared libraries with custom filenames, not
just the default pattern. This is required to write a rule that produces
python native extensions which have entirely different output naming
formats than standard shared libraries.
This API has been around for years now so I assume it's well understood
enough and there isn't a clear alternative.