5.046.bcr.2: make compilation work on hermetic systems.#8273
Closed
hzeller wants to merge 1 commit intobazelbuild:mainfrom
Closed
5.046.bcr.2: make compilation work on hermetic systems.#8273hzeller wants to merge 1 commit intobazelbuild:mainfrom
hzeller wants to merge 1 commit intobazelbuild:mainfrom
Conversation
`py_binary()` uses the local system python to launch the
script. It usees `/usr/bin/env python3` for that, which
looks at the $PATH.
By default, the PATH is compiled into bazel to look in
some limited set of directories (e.g. `/bin:/usr/bin`)
On hermetic systems, these paths do not contain that binary,
but are selectively made visible via `$PATH`.
So until `rules_python` provides a fully hermetic experience,
we need to work around that with `use_default_shell_env`.
Added a variable that set that value and provides an explanation.
While at it
* update `m4` dependency as the old one has compile errors.
* remove `MODULE.bazel` from overlay, as only the toplevel
one is needed.
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Member
|
Hello @UebelAndre, modules you maintain (verilator) have been updated in this PR. |
Contributor
Author
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
Contributor
Contributor
Author
|
Oh, yeah, that seems to work, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
py_binary()uses the local system python to launch the script. It usees/usr/bin/env python3for that, which looks at the $PATH.By default, the PATH is compiled into bazel to look in some limited set of directories (e.g.
/bin:/usr/bin)On hermetic systems, these paths do not contain that binary, but are selectively made visible via
$PATH.So until
rules_pythonprovides a fully hermetic experience, we need to work around that withuse_default_shell_env.Added a variable that set that value and provides an explanation.
While at it
m4dependency as the old one has compile errors.MODULE.bazelfrom overlay, as only the toplevel one is needed.