Skip to content

capnp-cpp@1.4.0#8215

Open
pgerell wants to merge 1 commit intobazelbuild:mainfrom
pgerell:add-capnp-cpp-1.4.0
Open

capnp-cpp@1.4.0#8215
pgerell wants to merge 1 commit intobazelbuild:mainfrom
pgerell:add-capnp-cpp-1.4.0

Conversation

@pgerell
Copy link
Copy Markdown

@pgerell pgerell commented Mar 30, 2026

Adds Cap'n Proto C++ v1.4.0 to the registry.

Patches:

  • update-module-version.patch: Updates the version field in MODULE.bazel from 1.1.0 to 1.4.0 (the upstream source was not updated when the release was cut).
  • bazelmod-compatible-boringssl.patch: Replaces @ssl with @boringssl//:ssl in kj-tls for Bzlmod compatibility.
  • fix-ez-rpc-includes.patch: Fixes bare includes in ez-rpc.h that don't work with Bazel's sandboxed include paths (see Build error + fix when using capnp/ez-rpc with bazel capnproto/capnproto#1942).

@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 30, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bazel-io
Copy link
Copy Markdown
Member

Hello @sebastianbergt, modules you maintain (capnp-cpp) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@pgerell
Copy link
Copy Markdown
Author

pgerell commented Mar 31, 2026

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Mar 31, 2026
Copy link
Copy Markdown
Contributor

@sebastianbergt sebastianbergt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @pgerell !

Copy link
Copy Markdown
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@pgerell
Copy link
Copy Markdown
Author

pgerell commented Apr 15, 2026

@bazelbuild/bcr-maintainers Is there anything I need to do?

@pgerell
Copy link
Copy Markdown
Author

pgerell commented Apr 20, 2026

Hi @meteorcloudy, are you the right person to ask about unblocking the Buildkite presubmit?

@jwnimmer-tri
Copy link
Copy Markdown
Contributor

FYI now that #8460 has landed, I think if you push any new update (e.g., rebase to latest main and force-push) the bcr_validation will pass -- it looks like all of the changes are probably innocuous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants