Skip to content

fourward@20260405.1#8183

Open
smolkaj wants to merge 1 commit intobazelbuild:mainfrom
smolkaj:fourward-20260329.0
Open

fourward@20260405.1#8183
smolkaj wants to merge 1 commit intobazelbuild:mainfrom
smolkaj:fourward-20260329.0

Conversation

@smolkaj
Copy link
Copy Markdown
Contributor

@smolkaj smolkaj commented Mar 29, 2026

Summary

Initial BCR release of 4ward, a
spec-compliant reference implementation of P4₁₆ and P4Runtime for
dataplane validation and testing.

Depends on #8332 (`grpc@1.80.0.bcr.1`) for BCR presubmit
compatibility — grpc 1.80.0 declares `rules_swift@2.5.0` which
conflicts with Bazel 9's bundled `rules_swift@3.1.2` during the
vendor step (filed #8331).

BCR patch

Strips `git_override` blocks (p4c, grpc, behavioral_model,
bazel_clang_tidy) and non-BCR dev dependencies. Pins grpc to
`1.80.0.bcr.1` (rules_swift fix).

Consumer impact

Consuming Consumer MODULE.bazel needs
`//simulator`, `//p4c_backend`, `//web`, `//cli` nothing
`//p4runtime:p4runtime_lib` `known_contributing_modules = ["grpc-java", "protobuf"]` (example)

Local verification

All steps pass locally before submission:

  • `bcr_validation` — all GOOD
  • `setup_presubmit_repos` vendor step — passes with Bazel 9 (`USE_BAZEL_VERSION=latest`)
  • Full build from `bcr_test_module` — 82 targets pass with Bazel 8
  • BCR presubmit CI (blocked on grpc@1.80.0.bcr.1 #8332)

@bazel-io
Copy link
Copy Markdown
Member

Hello BCR maintainers, modules without existing maintainers (fourward) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@bazel-io bazel-io requested review from a team and keith and removed request for a team March 29, 2026 09:38
@smolkaj smolkaj force-pushed the fourward-20260329.0 branch 3 times, most recently from 85a101a to cda0b4d Compare March 29, 2026 09:41
@smolkaj
Copy link
Copy Markdown
Contributor Author

smolkaj commented Apr 1, 2026

Gentle ping, this is ready for review.

@smolkaj
Copy link
Copy Markdown
Contributor Author

smolkaj commented Apr 4, 2026

@keith ready to be merged on my end.

keith
keith previously approved these changes Apr 4, 2026
@keith keith enabled auto-merge (squash) April 4, 2026 18:43
@keith
Copy link
Copy Markdown
Member

keith commented Apr 4, 2026

ci failures

auto-merge was automatically disabled April 5, 2026 04:43

Head branch was pushed to by a user without write access

@smolkaj smolkaj force-pushed the fourward-20260329.0 branch from cda0b4d to 9a4b4e3 Compare April 5, 2026 04:43
@bazel-io bazel-io dismissed keith’s stale review April 5, 2026 04:44

Require module maintainers' approval for newly pushed changes.

@bazel-io bazel-io requested a review from keith April 5, 2026 04:44
@smolkaj
Copy link
Copy Markdown
Contributor Author

smolkaj commented Apr 5, 2026

ci failures

Fixed, ready to merge

keith
keith previously approved these changes Apr 5, 2026
@keith keith enabled auto-merge (squash) April 5, 2026 17:12
@keith
Copy link
Copy Markdown
Member

keith commented Apr 5, 2026

failed

@smolkaj smolkaj closed this Apr 5, 2026
auto-merge was automatically disabled April 5, 2026 18:23

Pull request was closed

@smolkaj smolkaj mentioned this pull request Apr 5, 2026
@smolkaj smolkaj reopened this Apr 5, 2026
@bazel-io bazel-io dismissed keith’s stale review April 5, 2026 18:43

Require module maintainers' approval for newly pushed changes.

@bazel-io bazel-io requested a review from keith April 5, 2026 18:43
@smolkaj smolkaj force-pushed the fourward-20260329.0 branch from 9a4b4e3 to 73e4c90 Compare April 5, 2026 18:43
@smolkaj smolkaj changed the title fourward@20260329.0 fourward@20260405.0 Apr 5, 2026
@UebelAndre
Copy link
Copy Markdown
Contributor

Why not call it 4ward?

@smolkaj
Copy link
Copy Markdown
Contributor Author

smolkaj commented Apr 5, 2026

Why not call it 4ward?

I'd love to, but it seems Bzlmod doesn't allow that: https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileGlobals.java#L72-L74

@smolkaj smolkaj force-pushed the fourward-20260329.0 branch from fa82ee5 to b3daa17 Compare April 6, 2026 00:26
@smolkaj smolkaj changed the title fourward@20260405.0 fourward@20260405.1 Apr 6, 2026
@smolkaj smolkaj force-pushed the fourward-20260329.0 branch 2 times, most recently from ea4fe1c to b58b7bc Compare April 6, 2026 01:57
@smolkaj
Copy link
Copy Markdown
Contributor Author

smolkaj commented Apr 6, 2026

@keith took another crack at it, this time adding a bcr_test_module to my repo first to prefetch potential issue (smolkaj/4ward#475).

keith
keith previously approved these changes Apr 6, 2026
@keith keith enabled auto-merge (squash) April 6, 2026 16:41
@keith
Copy link
Copy Markdown
Member

keith commented Apr 6, 2026

failed

@smolkaj
Copy link
Copy Markdown
Contributor Author

smolkaj commented Apr 6, 2026

Seems like a BCR issue :/ #8331

Currently hard-blocked, not sure what to do as a workaround :(

@smolkaj smolkaj mentioned this pull request Apr 6, 2026
auto-merge was automatically disabled April 6, 2026 23:32

Head branch was pushed to by a user without write access

@smolkaj smolkaj force-pushed the fourward-20260329.0 branch from b58b7bc to e57a3b1 Compare April 6, 2026 23:32
@bazel-io bazel-io dismissed keith’s stale review April 6, 2026 23:33

Require module maintainers' approval for newly pushed changes.

@bazel-io bazel-io requested a review from keith April 6, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants