Skip to content

{rules_python,rules_python_gazelle_plugin}@1.7.0-rc5#6431

Closed
bazel-contrib-bot wants to merge 1 commit intobazelbuild:mainfrom
bazel-contrib:rules_python,rules_python_gazelle_plugin-1.7.0-rc5
Closed

{rules_python,rules_python_gazelle_plugin}@1.7.0-rc5#6431
bazel-contrib-bot wants to merge 1 commit intobazelbuild:mainfrom
bazel-contrib:rules_python,rules_python_gazelle_plugin-1.7.0-rc5

Conversation

@bazel-contrib-bot
Copy link
Copy Markdown
Contributor

@bazel-io
Copy link
Copy Markdown
Member

bazel-io commented Nov 6, 2025

Hello @rickeylev, @aignas, modules you maintain (rules_python, rules_python_gazelle_plugin) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@aignas aignas mentioned this pull request Nov 6, 2025
17 tasks
@aignas
Copy link
Copy Markdown
Contributor

aignas commented Nov 6, 2025

I forgot to cherry pick bazel-contrib/rules_python#3389. If the pre-submit fails, I'll let's close this PR and I'll create an rc6.

@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Nov 6, 2025
Copy link
Copy Markdown
Contributor

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now we should change the tested versions to be 8.x

matrix:
platform: ["debian11", "macos", "ubuntu2004", "windows"]
# last_rc is to get latest 8.x release. Replace with 8.x when available.
bazel: [7.x, last_rc]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bazel: [7.x, last_rc]
bazel: [7.x, 8.x]

matrix:
platform: ["debian11", "macos", "ubuntu2004", "windows"]
# last_rc is to get latest 8.x release. Replace with 8.x when available.
bazel: [7.x, last_rc]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bazel: [7.x, last_rc]
bazel: [7.x, 8.x]

@aignas
Copy link
Copy Markdown
Contributor

aignas commented Nov 6, 2025

Fix in bazel-contrib/rules_python#3395

@aignas
Copy link
Copy Markdown
Contributor

aignas commented Nov 6, 2025

I think we should close this

@Wyverald Wyverald closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants