Cherry-pick conditional removal of apple_fragment.*_sdk_version_flag attributes#499
Open
brentleyjones wants to merge 2 commits intomainfrom
Conversation
…` attributes PiperOrigin-RevId: 864869707 (cherry picked from commit d9ecf92) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
requested review from
aaronsky,
adincebic,
keith,
luispadron and
mattrobmattrob
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
4 tasks
brentleyjones
commented
Feb 4, 2026
| watchos_sdk_version = apple_fragment.watchos_sdk_version_flag or _dotted_version_or_default(xcode_version_properties.default_watchos_sdk_version, "2.0") | ||
| # TODO: Remove `getattr` once we no longer support a version of Bazel with | ||
| # `apple_fragment.*_sdk_version_flag` | ||
| ios_sdk_version = getattr(apple_fragment, "ios_sdk_version_flag", None) or _dotted_version_or_default(xcode_version_properties.default_ios_sdk_version, "8.4") |
Collaborator
Author
There was a problem hiding this comment.
Since apple_fragment itself is also going away soon, do we need to also gate that?
adincebic
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 864869707
(cherry picked from commit d9ecf92)