#39 Remove usage of deprecated build-in http_archive rule.#40
#39 Remove usage of deprecated build-in http_archive rule.#40greggdonovan wants to merge 1 commit intomasterfrom
Conversation
Also: - Move tools/bazel.rc to support new locations: https://docs.bazel.build/versions/master/guide.html#where-are-the-bazelrc-files. - Build with as many incompatible changes as possible. - Update bazel-deps and rules_scala. - Removed no longer needed scala maven workarounds.
|
Sure, I just sent you an invite. |
|
|
||
| # Build with as much future compatibility as possible | ||
| # See https://docs.bazel.build/versions/master/skylark/backward-compatibility.html | ||
| # TODO We have protobuf 3.6.1 in the WORKSPACE but an older protobuf is causing the errors below. Why? |
There was a problem hiding this comment.
do you know what external dependency it's getting picked up from?
petroseskinder
left a comment
petroseskinder
left a comment
There was a problem hiding this comment.
LGTM. Thanks for making the changes. I haven't been actively monitoring this, of late.
|
@buchgr @philwo @fweikert could I also get access to BuildKite? I blanket approved so that once @greggdonovan figures out the errors he wouldn't be blocked needing a review. |
|
@petroseskinder Sure. I didn't realize Bazel CI uses 0.18.0, so I'm making a PR with just those changes for now to get CI to pass. |
|
@greggdonovan The Macs already run 0.19.0, and philwo@ is in the process of updating the other platforms, too. |
3 participants
Also: