This repository was archived by the owner on Jan 26, 2022. It is now read-only.
Add motivation and rudimentary running instructions to README.md#34
Merged
cgrushko merged 2 commits intobazelbuild:masterfrom Jan 18, 2018
Merged
Add motivation and rudimentary running instructions to README.md#34cgrushko merged 2 commits intobazelbuild:masterfrom
cgrushko merged 2 commits intobazelbuild:masterfrom
Conversation
Contributor
Author
|
@spomorski I can't add you to the list of reviewers for some reason. |
|
I think you or someone with permissions has to give me write access to that
repository.
…On Dec 18, 2017 23:31, "Carmi Grushko" ***@***.***> wrote:
@spomorski <https://github.com/spomorski> I can't add you to the list of
reviewers for some reason.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AbdI8ssKw-pdkYnR4VThkrQg_kEZ0hF2ks5tBzwRgaJpZM4RGbZ9>
.
|
sergetron
approved these changes
Jan 18, 2018
sergetron
reviewed
Jan 18, 2018
|
Disregard my last comment, I misread the commit. :)
…On Thu, Jan 18, 2018 at 1:07 PM, Serge ***@***.***> wrote:
***@***.**** commented on this pull request.
Can we also add the usage instructions? We need this to update the Maven
migration guide.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#34 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AbdI8pPhLUq9SUjeAG6IBKZtPdzoJ-Xxks5tL4hggaJpZM4RGbZ9>
.
|
Contributor
Author
|
@spomorski we recently discovered that there's some bug in BFG which makes it not work, so even with instructions it might not be good enough yet. |
|
Thanks for the info, any ETA on the fix?
…On Thu, Jan 18, 2018 at 1:44 PM, Carmi Grushko ***@***.***> wrote:
@spomorski <https://github.com/spomorski> we recently discovered that
there's some bug in BFG which makes it not work, so even with instructions
it might not be good enough yet.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AbdI8oIPFT40Ik1TDGyYzsQbIP6IRBH5ks5tL5EPgaJpZM4RGbZ9>
.
|
Contributor
Author
|
Er... not yet :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on @petroseskinder 's #24.