This repository was archived by the owner on Jan 26, 2022. It is now read-only.
Update check-deps with check-only option#28
Open
greggdonovan wants to merge 2 commits intobazelbuild:masterfrom
Open
Update check-deps with check-only option#28greggdonovan wants to merge 2 commits intobazelbuild:masterfrom
check-deps with check-only option#28greggdonovan wants to merge 2 commits intobazelbuild:masterfrom
Conversation
… but bazeltools/bazel-deps#62 is still open.
|
|
||
| # Fail if the generated files don't match what's committed. | ||
| if ! diff -u <(echo "$BEFORE") <(echo "$AFTER") | ||
| if ! "$BAZEL_DEPS_DIR/gen_maven_deps.sh" generate --check-only --buildifier buildifier --repo-root "${ROOT_DIR}" --sha-file thirdparty/workspace.bzl --deps maven_deps.yaml |
There was a problem hiding this comment.
You can should use --buildifier in setup.sh as well for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
check-onlyoption has been created by @kevingessner but autovalue support is still open.