Skip to content

fix: remove flag_aliases to unbreak bazel 9 #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 1 commit into from
Mar 5, 2026
+22 −19
Merged

fix: remove flag_aliases to unbreak bazel 9 #3649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 22 additions & 19 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,22 +460,25 @@ uv_dev.configure(
version = "0.6.2",
)

flag_alias(
name = "build_python_zip",
starlark_flag = "//python/config_settings:build_python_zip",
)

flag_alias(
name = "incompatible_default_to_explicit_init_py",
starlark_flag = "//python/config_settings:incompatible_default_to_explicit_init_py",
)

flag_alias(
name = "python_path",
starlark_flag = "//python/config_settings:python_path",
)

flag_alias(
name = "experimental_python_import_all_repositories",
starlark_flag = "//python/config_settings:experimental_python_import_all_repositories",
)
# Temporarily comment out these flag aliases because they break Bazel 9
# when transitions are also used with a target.
Comment on lines +463 to +464
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This comment provides good context. To make this temporary change easier to track and revert, consider adding a TODO with a reference to the issue. This helps ensure it's addressed once the underlying Bazel bug is fixed.

Suggested change
# Temporarily comment out these flag aliases because they break Bazel 9
# when transitions are also used with a target.
# TODO(#3648): Uncomment when the Bazel 9 bug with flag_alias is fixed.
# These are temporarily commented out to unbreak builds with transitions.

#
# flag_alias(
# name = "build_python_zip",
# starlark_flag = "//python/config_settings:build_python_zip",
# )

# flag_alias(
# name = "incompatible_default_to_explicit_init_py",
# starlark_flag = "//python/config_settings:incompatible_default_to_explicit_init_py",
# )

# flag_alias(
# name = "python_path",
# starlark_flag = "//python/config_settings:python_path",
# )

# flag_alias(
# name = "experimental_python_import_all_repositories",
# starlark_flag = "//python/config_settings:experimental_python_import_all_repositories",
# )