Skip to content

ci: disable soft-fail jobs to unbreak ci #3647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rickeylev wants to merge 1 commit into from
+17 −14
Closed

ci: disable soft-fail jobs to unbreak ci #3647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions .bazelci/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,20 +194,23 @@ tasks:
name: "Default: Ubuntu, upcoming Bazel"
platform: ubuntu2204
bazel: last_rc
ubuntu_rolling:
name: "Default: Ubuntu, rolling Bazel"
platform: ubuntu2204
bazel: rolling
# This is an advisory job; doesn't block merges
soft_fail:
- exit_status: 1
- exit_status: 3
test_targets:
- "--"
- "//tests/..."
test_flags:
- "--keep_going"
- "--test_tag_filters=-integration-test"
# Temporarily remove this job to avoid all of CI failing
# Can be re-enabled after BazelCI is fixed, see
# https://github.com/bazelbuild/continuous-integration/pull/2487
Comment on lines +197 to +199
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comments clearly explain the temporary nature of this change. To further improve maintainability and ensure this temporary disablement is easily discoverable for future re-enablement, consider adding a TODO tag with a specific identifier (e.g., TODO(bazelci-bug)) to mark this as an item to revisit once the upstream issue is resolved. This makes it easier to track and search for such temporary workarounds.

  # TODO(bazelci-bug): Re-enable this job after BazelCI is fixed.
  # See https://github.com/bazelbuild/continuous-integration/pull/2487
  # Temporarily removed to avoid all of CI failing.

# ubuntu_rolling:
# name: "Default: Ubuntu, rolling Bazel"
# platform: ubuntu2204
# bazel: rolling
# # This is an advisory job; doesn't block merges
# soft_fail:
# - exit_status: 1
# - exit_status: 3
# test_targets:
# - "--"
# - "//tests/..."
# test_flags:
# - "--keep_going"
# - "--test_tag_filters=-integration-test"
ubuntu_workspace:
<<: *reusable_config
<<: *common_workspace_flags
Expand Down